diff options
| author | dank@chromium.org <dank@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-26 22:45:11 +0000 |
|---|---|---|
| committer | dank@chromium.org <dank@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-26 22:45:11 +0000 |
| commit | 9970340aaa6c19345041261acb516a6c7bbd2bed (patch) | |
| tree | 22a8bcee5fbf36e19be36f6056e531e441346ff9 /tools/valgrind/valgrind_test.py | |
| parent | 3ee085030c6bc6119248f856313266b1a354143c (diff) | |
| download | chromium_src-9970340aaa6c19345041261acb516a6c7bbd2bed.zip chromium_src-9970340aaa6c19345041261acb516a6c7bbd2bed.tar.gz chromium_src-9970340aaa6c19345041261acb516a6c7bbd2bed.tar.bz2 | |
Reverting 24548.
Review URL: http://codereview.chromium.org/174576
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24551 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind/valgrind_test.py')
| -rwxr-xr-x | tools/valgrind/valgrind_test.py | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py index 14d3076..5160ffe 100755 --- a/tools/valgrind/valgrind_test.py +++ b/tools/valgrind/valgrind_test.py @@ -181,18 +181,6 @@ class ValgrindTool(object): shutil.copyfile(dsym_file, test_command) shutil.copymode(saved_test_command, test_command) - # Make sure the Chromium Framework symbols are available. - # See message from mmentovai on aug 5 - build_dir = os.path.dirname(test_command) - symlink_source = '../../../Chromium Framework.framework.dSYM' - symlink_target = build_dir + '/Chromium.app/Contents/Frameworks/Chromium Framework.framework.dSYM' - try: - os.remove(symlink_target) - except IOError, (errno, strerror): - pass - logging.info('Trying ln -s "%s" "%s"' % (symlink_source, symlink_target)) - os.symlink(symlink_source, symlink_target) - if needs_dsymutil: if self._options.generate_dsym: # Remove the .dSYM bundle if it exists. @@ -376,7 +364,7 @@ class Memcheck(ValgrindTool): filenames = glob.glob(self.TMP_DIR + "/memcheck.*") use_gdb = (sys.platform == 'darwin') - analyzer = memcheck_analyze.MemcheckAnalyze(self._source_dir, filenames, self._options.show_all_leaks, + analyzer = memcheck_analyze.MemcheckAnalyze(self._source_dir, filenames, self._options.show_all_leaks, use_gdb=use_gdb) return analyzer.Report() |