diff options
| author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-27 21:09:39 +0000 |
|---|---|---|
| committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-27 21:09:39 +0000 |
| commit | a7ac93666794a791764861666053f667e52d5a68 (patch) | |
| tree | 1d0548a0330615f8f2646e246f26a90f35475a34 /tools/valgrind/valgrind_test.py | |
| parent | 833fa265a5239fca9c675fb029cd2ef53b5c5aa7 (diff) | |
| download | chromium_src-a7ac93666794a791764861666053f667e52d5a68.zip chromium_src-a7ac93666794a791764861666053f667e52d5a68.tar.gz chromium_src-a7ac93666794a791764861666053f667e52d5a68.tar.bz2 | |
Added printing of a couple of links to documentation in case warnings are reporteed.
I think this may increase the popularity and usability of our tools.
Review URL: http://codereview.chromium.org/343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30246 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind/valgrind_test.py')
| -rwxr-xr-x | tools/valgrind/valgrind_test.py | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py index bdbdd0c..448965a 100755 --- a/tools/valgrind/valgrind_test.py +++ b/tools/valgrind/valgrind_test.py @@ -366,7 +366,11 @@ class Memcheck(ValgrindTool): use_gdb = (sys.platform == 'darwin') analyzer = memcheck_analyze.MemcheckAnalyze(self._source_dir, filenames, self._options.show_all_leaks, use_gdb=use_gdb) - return analyzer.Report() + ret = analyzer.Report() + if ret != 0: + logging.info("Please see http://dev.chromium.org/developers/how-tos/" + "using-valgrind for the info on Memcheck/Valgrind") + return ret class ThreadSanitizer(ValgrindTool): """ThreadSanitizer""" @@ -436,7 +440,12 @@ class ThreadSanitizer(ValgrindTool): use_gdb = (sys.platform == 'darwin') analyzer = tsan_analyze.TsanAnalyze(self._source_dir, filenames, use_gdb=use_gdb) - return analyzer.Report() + ret = analyzer.Report() + if ret != 0: + logging.info("Please see http://dev.chromium.org/developers/how-tos/" + "using-valgrind/threadsanitizer for the info on " + "ThreadSanitizer") + return ret class ToolFactory: @@ -445,7 +454,9 @@ class ToolFactory: return Memcheck() if tool_name == "tsan": if sys.platform != 'linux2': - logging.info("WARNING: ThreadSanitizer is not working yet on Mac") + logging.info("WARNING: ThreadSanitizer may be unstable on Mac.") + logging.info("See http://code.google.com/p/data-race-test/wiki/" + "ThreadSanitizerOnMacOsx for the details") return ThreadSanitizer() raise RuntimeError, "Unknown tool" \ "(tool=%s, platform=%s)" % \ |