diff options
author | timurrrr <timurrrr@chromium.org> | 2014-10-02 08:25:17 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-02 15:25:34 +0000 |
commit | 624be8ed861888e0ef75e7e90881363eaa6213f8 (patch) | |
tree | 66c889eea56720e808111f64c10b7e3b3f4f68ed /tools/valgrind/valgrind_test.py | |
parent | 1b9a4e05b28cc09dab1815a35da6f13259fab504 (diff) | |
download | chromium_src-624be8ed861888e0ef75e7e90881363eaa6213f8.zip chromium_src-624be8ed861888e0ef75e7e90881363eaa6213f8.tar.gz chromium_src-624be8ed861888e0ef75e7e90881363eaa6213f8.tar.bz2 |
Check that the user doesn't try to run ASan-built binaries under Valgrind etc
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/624533003
Cr-Commit-Position: refs/heads/master@{#297836}
Diffstat (limited to 'tools/valgrind/valgrind_test.py')
-rw-r--r-- | tools/valgrind/valgrind_test.py | 40 |
1 files changed, 0 insertions, 40 deletions
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py index 29903d9..f568b5e 100644 --- a/tools/valgrind/valgrind_test.py +++ b/tools/valgrind/valgrind_test.py @@ -1165,44 +1165,6 @@ class RaceVerifier(object): return self.Main(args, False, min_runtime_in_seconds) -class EmbeddedTool(BaseTool): - """Abstract class for tools embedded directly into the test binary. - """ - # TODO(glider): need to override Execute() and support process chaining here. - - def ToolCommand(self): - # In the simplest case just the args of the script. - return self._args - - -class Asan(EmbeddedTool): - """AddressSanitizer, a memory error detector. - - More information at - http://dev.chromium.org/developers/testing/addresssanitizer - """ - def __init__(self): - super(Asan, self).__init__() - self._timeout = 1200 - if common.IsMac(): - self._env["DYLD_NO_PIE"] = "1" - - - def ToolName(self): - return "asan" - - def ToolCommand(self): - # TODO(glider): use pipes instead of the ugly wrapper here once they - # are supported. - procs = [os.path.join(self._source_dir, "tools", "valgrind", - "asan", "asan_wrapper.sh")] - procs.extend(self._args) - return procs - - def Analyze(sels, unused_check_sanity): - return 0 - - class ToolFactory: def Create(self, tool_name): if tool_name == "memcheck": @@ -1223,8 +1185,6 @@ class ToolFactory: return DrMemory(False, True) if tool_name == "tsan_rv": return RaceVerifier() - if tool_name == "asan": - return Asan() try: platform_name = common.PlatformNames()[0] except common.NotImplementedError: |