Suppress drmemory false positives and PasswordStore leaks with a pending fix.

TBR=bruening@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9474015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123798 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 38 insertions, 13 deletions

diff --git a/tools/valgrind/drmemory/suppressions_full.txt b/tools/valgrind/drmemory/suppressions_full.txt
index b2d6770..8649c47 100644
--- a/tools/valgrind/drmemory/suppressions_full.txt
+++ b/tools/valgrind/drmemory/suppressions_full.txt
@@ -492,21 +492,25 @@ CRYPT32.dll!CertGetCertificateChain
 
 LEAK
 name=http://code.google.com/p/drmemory/issues/detail?id=476 f
-RPCRT4.dll!*
 ...
 CRYPT32.dll!CertCompareIntegerBlob
 
 LEAK
-name=http://code.google.com/p/drmemory/issues/detail?id=476 i
+name=http://code.google.com/p/drmemory/issues/detail?id=476 g
 ...
 CRYPT32.dll!CryptUnprotectData
 
 LEAK
-name=http://code.google.com/p/drmemory/issues/detail?id=476 j
+name=http://code.google.com/p/drmemory/issues/detail?id=476 h
 KERNEL*.dll!LocalAlloc
 ...
 CRYPT32.dll!CertEnumCertificatesInStore
 
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=476 i
+...
+CRYPT32.dll!CryptProtectData
+
 UNINITIALIZED READ
 name=http://code.google.com/p/drmemory/issues/detail?id=502 a
 system call NtSecureConnectPort parameter #3
@@ -587,7 +591,7 @@ dbghelp.dll!StackWalk64
 # Symbols w/o PDB make no sense, first ntdll frame is TpSetTimer w/o syms and
 # TppWorkerThread w/ syms.  We used to use mod+offs here, but that was too
 # brittle, so we switched to RPCRT4.dll!*.
-POSSIBLE LEAK
+LEAK
 name=http://code.google.com/p/drmemory/issues/detail?id=569
 RPCRT4.dll!...
 ntdll.dll!*
@@ -665,7 +669,7 @@ CRYPT32.dll!I_CertSyncStore
 # a leak.  Must be some early thread initialization.  Doesn't look like
 # bit-level though.
 UNINITIALIZED READ
-name=http://crbug.com/TODO o
+name=http://crbug.com/TODO n
 RPCRT4.dll!*
 RPCRT4.dll!*
 RPCRT4.dll!*
@@ -673,6 +677,22 @@ ntdll.dll!*
 ntdll.dll!*
 KERNEL*.dll!BaseThreadInitThunk
 
+# No idea where this is from, but Chrome isn't even on the stack.
+POSSIBLE LEAK
+name=http://crbug.com/TODO o
+RPCRT4.dll!...
+ole32.dll!OleInitialize
+ole32.dll!...
+KERNEL32.dll!BaseThreadInitThunk
+
+# Matches lots of RPC related leaks.  So far RPC handles have been mostly owned
+# by system libraries and are not something we can fix easily.
+POSSIBLE LEAK
+name=http://crbug.com/TODO p
+RPCRT4.dll!*
+RPCRT4.dll!*
+RPCRT4.dll!NDRCContextBinding
+
 LEAK
 name=http://crbug.com/109278 video device COM leaks
 ...
@@ -821,13 +841,6 @@ name=http://code.google.com/p/drmemory/issues/detail?id=778 c
 *!_PR_AttachThread
 *!_PRI_AttachThread
 
-# Needs more investigation...
-POSSIBLE LEAK
-name=NOCHECKIN
-RPCRT4.dll!*
-RPCRT4.dll!*
-RPCRT4.dll!NDRCContextBinding
-
 # Bit-level fps in rich edit layer.
 UNINITIALIZED READ
 name=http://code.google.com/p/drmemory/issues/detail?id=791
@@ -843,6 +856,13 @@ RPCRT4.dll!*
 SspiCli.dll!*
 SspiCli.dll!Cre*
 
+# Async NtReadFile false positives.  This was fixed in drmemory r772, remove
+# this supp when we pull that rev.
+UNADDRESSABLE ACCESS
+name=http://code.google.com/p/drmemory/issues/detail?id=798
+system call NtReadFile parameter #5
+KERNEL32.dll!ReadFile
+
 ###############################################################
 # Benign issues in Chromium
 
@@ -1081,11 +1101,16 @@ name=http://crbug.com/115197
 # PasswordStoreWinTest.Migration creates leaks.  Some sqlite issue?  Reproduces
 # locally.
 LEAK
-name=http://crbug.com/115191
+name=http://crbug.com/115191 a
 ...
 *!PasswordStoreWinTest::SetUp
 
 LEAK
+name=http://crbug.com/115191 b
+...
+*!PasswordStoreWinTest_Migration_Test::TestBody
+
+LEAK
 name=http://crbug.com/115328
 ...
 *!GenericInfoViewTest_GenericInfoView_Test::TestBody