diff options
author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-26 11:52:36 +0000 |
---|---|---|
committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-26 11:52:36 +0000 |
commit | 5f46ed5ef581d34d3bf6d24d3a38d27b206f3c97 (patch) | |
tree | 98cb2e19d8fe13eca7a4053a5564591ba287d130 /tools/valgrind | |
parent | 430d228cb2ba215820bcbb021986d78149e46524 (diff) | |
download | chromium_src-5f46ed5ef581d34d3bf6d24d3a38d27b206f3c97.zip chromium_src-5f46ed5ef581d34d3bf6d24d3a38d27b206f3c97.tar.gz chromium_src-5f46ed5ef581d34d3bf6d24d3a38d27b206f3c97.tar.bz2 |
Update ThreadSanitizer ignore file
1) Added the link to the ignore files documentation
2) Fixed a typo
3) Used new "fun_r" instead of "fun" for a couple of functions to speed up some large tests from net_, unit_ and ui_.
4) Used new "fun_hist" for unibrow namespace to do coarser history tracking - bottleneck on unit_.
Please see http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores
for the details of new ignore rules. They are present since the new TSAN version (rev1274)
TBR=dank
TEST=TSAN bots should remain green AND become faster.
Review URL: http://codereview.chromium.org/441028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33203 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind')
-rw-r--r-- | tools/valgrind/tsan/ignores.txt | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/tools/valgrind/tsan/ignores.txt b/tools/valgrind/tsan/ignores.txt index d8bf65e..e7274f6 100644 --- a/tools/valgrind/tsan/ignores.txt +++ b/tools/valgrind/tsan/ignores.txt @@ -1,5 +1,6 @@ # This file lists the functions, object files and source files # which should be ignored (i.e. not instrumented) by ThreadSanitizer. +# See http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores. # ignore these libraries obj:*/ld-2* @@ -16,9 +17,9 @@ obj:*/nss/* fun:clone fun:fork fun:pthread_* -fun:random_r -fun:random -fun:rand +fun_r:random_r +fun_r:random +fun_r:rand fun:__lll_mutex_unlock_wake fun:__cxa_atexit fun:__new_exitfn @@ -50,7 +51,7 @@ fun:*_M_set_sharable* src:*ts_valgrind_intercepts.c ################################################################## -# Don't instrument syncronization code +# Don't instrument synchronization code src:*base/waitable_event* src:*base/atomic* src:*base/condition_variable* @@ -59,14 +60,16 @@ src:*base/stats_counters* src:*base/thread_local_storage_posix* # This function is heavy in net_unittests -fun:*disk_cache*BackendImpl*CheckAllEntries* +fun_r:*disk_cache*BackendImpl*CheckAllEntries* # V8 is a hot-spot under ThreadSanitizer. # Lots of tiny functions there... -# TODO(timurrrr): Should we use coarser segment granularity for this file? +# TODO(timurrrr): # Can we miss data races on V8 objects due to non thread-safe API calls # if we don't instrument v8::internals? -fun:*v8*internal* +fun_r:*v8*internal* +# unibrow namespace contains lots of tiny unicode conversion functions. +fun_hist:*unibrow* # TODO(timurrrr): SKIA - needs separate testing? # SKIA unittest is single-threaded... |