diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 04:48:53 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 04:48:53 +0000 |
| commit | 81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12 (patch) | |
| tree | 41b3caf1a55ba3cfa2f6cf13b0a5ce3d773d631f /tools/valgrind | |
| parent | 4f7f4854821e8e4933ad2c662bfd9417eb604a68 (diff) | |
| download | chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.zip chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.tar.gz chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.tar.bz2 | |
Use lock-free lazy initialization for static histogram references
Make all histogram macros thread safe, and fast by again
using statics to achieve performance.
...at the cost of:
Leak all histograms to avoid races at shutdown.
Also included leak suppression for valgrind.
r=rtenneti
BUG=78207
Review URL: http://codereview.chromium.org/6780035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80412 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 5bd5b68..148abe3 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -877,6 +877,20 @@ fun:PL_ArenaAllocate fun:PORT_ArenaAlloc_Util } +{ + # Histograms are used on un-joined threads, and can't be deleted atexit. + Histograms via FactoryGet including Linear Custom Boolean and Basic + Memcheck:Leak + fun:_Znw* + fun:_ZN4base*Histogram10FactoryGet* +} +{ + # Histograms are used on un-joined threads, and can't be deleted atexit. + Histograms via FactoryGet including Stats for disk_cache + Memcheck:Leak + fun:_Znw* + fun:_ZN10disk_cache14StatsHistogram24StatsHistogramFactoryGet* +} #----------------------------------------------------------------------- # 3. Suppressions for real chromium bugs that are not yet fixed. |