diff options
| author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-21 16:07:51 +0000 |
|---|---|---|
| committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-21 16:07:51 +0000 |
| commit | b6ef1e7b282dcb47d82eb2970df8619ed93f06c0 (patch) | |
| tree | 8db5530e72b71c148ffde218e88c6a2908b746b1 /tools/valgrind | |
| parent | 6c61386bad28a8df67b717b129798f48849d8248 (diff) | |
| download | chromium_src-b6ef1e7b282dcb47d82eb2970df8619ed93f06c0.zip chromium_src-b6ef1e7b282dcb47d82eb2970df8619ed93f06c0.tar.gz chromium_src-b6ef1e7b282dcb47d82eb2970df8619ed93f06c0.tar.bz2 | |
Update TSan ignores and suppressions to give less false reports on UI tests.
TBR=glider
TEST=TSan/UI FYI goes greener
Review URL: http://codereview.chromium.org/6542046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75553 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools/valgrind')
| -rw-r--r-- | tools/valgrind/tsan/ignores.txt | 13 | ||||
| -rw-r--r-- | tools/valgrind/tsan/suppressions.txt | 11 |
2 files changed, 9 insertions, 15 deletions
diff --git a/tools/valgrind/tsan/ignores.txt b/tools/valgrind/tsan/ignores.txt index 832b308..0b7bc11 100644 --- a/tools/valgrind/tsan/ignores.txt +++ b/tools/valgrind/tsan/ignores.txt @@ -140,7 +140,12 @@ fun_r:*base*StatsTable*AddCounter* # TSan doesn't understand internal libc locks, see http://crbug.com/71435 fun_r:mbsrtowcs -# Suppress false reports below these memcpy and memset impls. -# See http://code.google.com/p/data-race-test/issues/detail?id=62 -fun:__memset_sse2 -fun:__GI_memcpy +# gethostbyname2_r is thread-safe, however ThreadSanitizer reports races inside it and +# (sometimes) in __nss_* functions below it. +# This may be related to +# https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/59449 +fun_r:gethostbyname2_r* + +# Strange reports below _IO_getline, every time in "Concurrent access". +# Probably the reports are there since we're missing the libc internal locks +fun_r:_IO_getline* diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt index 5de59b1..04b59a9 100644 --- a/tools/valgrind/tsan/suppressions.txt +++ b/tools/valgrind/tsan/suppressions.txt @@ -491,17 +491,6 @@ fun:timegm } -# gethostbyname2_r is thread-safe, however ThreadSanitizer reports races inside it and -# (sometimes) in __nss_* functions below it. -# This may be related to -# https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/59449 -{ - Race reports below thread-safe gethostbyname2_r - ThreadSanitizer:Race - ... - fun:gethostbyname2_r* -} - { Benign race in nss (PR_EnterMonitor) ThreadSanitizer:Race |