summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authortimurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-30 14:50:30 +0000
committertimurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-30 14:50:30 +0000
commit097f48d2f2ca4d24d5468d571c07e2e71749320a (patch)
tree910836680ce7c14af2ac40209e0ab987f536e017 /tools
parent6e2efc0462d72267c5a524411e4771e67da206e1 (diff)
downloadchromium_src-097f48d2f2ca4d24d5468d571c07e2e71749320a.zip
chromium_src-097f48d2f2ca4d24d5468d571c07e2e71749320a.tar.gz
chromium_src-097f48d2f2ca4d24d5468d571c07e2e71749320a.tar.bz2
Suppress two benign races
TBR=dank TEST=Linux TSAN bot green on unit_tests Review URL: http://codereview.chromium.org/343058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30579 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/valgrind/tsan/suppressions.txt23
1 files changed, 23 insertions, 0 deletions
diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt
index b2c3d0d..65740f4 100644
--- a/tools/valgrind/tsan/suppressions.txt
+++ b/tools/valgrind/tsan/suppressions.txt
@@ -112,6 +112,19 @@
fun:*talk_base*MessageQueue*Get*
}
+# The race happens during enumeration of ChromeThreads.
+# For each ChromeThread we check whether its message_loop()
+# equals MessageLoop::current().
+# The race can happen if one of the ChromeThreads is exiting.
+# This is benign since current thread can't exit while we
+# execute GetCurrentThreadIdentifier() and other message_loops
+# won't match the current one anyway.
+{
+ Benign race under ChromeThread::GetCurrentThreadIdentifier
+ fun:*base*Thread*message_loop*
+ fun:*ChromeThread*GetCurrentThreadIdentifier*
+}
+
############################
# Data races in tests
@@ -248,3 +261,13 @@
...
fun:_dl_close
}
+
+# fprintf is thread-safe. The benign races happen on the internal lock.
+{
+ Benign races below fprintf
+ ThreadSanitizer:Race
+ ...
+ fun:buffered_vfprintf
+ ...
+ fun:fprintf
+}