diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-05 23:14:23 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-05 23:14:23 +0000 |
| commit | 27bc9e8ac1922f88fbe003c9b050add4e27321b0 (patch) | |
| tree | b8144c740ebfe600da7f3de56048593a1c6a1903 /tools | |
| parent | de79ca9d31a185a8a965197b99fd628d9581b389 (diff) | |
| download | chromium_src-27bc9e8ac1922f88fbe003c9b050add4e27321b0.zip chromium_src-27bc9e8ac1922f88fbe003c9b050add4e27321b0.tar.gz chromium_src-27bc9e8ac1922f88fbe003c9b050add4e27321b0.tar.bz2 | |
Autofill heapcheck and valgrind leak in PersonalDataManager unit test fixed
An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test. This fixes it. Also, some small cleanup in the test itself.
BUG=61988
TEST=Memory bots stay green.
Review URL: http://codereview.chromium.org/4612001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65272 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 12 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 14 |
2 files changed, 0 insertions, 26 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index a3b2162..d89a553 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1054,18 +1054,6 @@ fun:testing::Test::Run } { - bug_61988_a - Heapcheck:Leak - ... - fun:PersonalDataManagerTest_Refresh_Test::TestBody -} -{ - bug_61988_b - Heapcheck:Leak - ... - fun:TestingProfile::CreateWebDataService -} -{ bug_62078 Heapcheck:Leak fun:__gnu_cxx::new_allocator::allocate diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 3bd23e8..ffa70e1 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -3196,17 +3196,3 @@ fun:_ZN23AutocompleteEditViewGtk6UpdateEPK11TabContents fun:_ZN15LocationBarView6UpdateEPK11TabContents } -{ - bug_61988_a - Memcheck:Leak - fun:_Znw* - ... - fun:_ZN14TestingProfile20CreateWebDataServiceEb - fun:_ZN23PersonalDataManagerTest5SetUpEv -} -{ - bug_61988_b - Memcheck:Leak - ... - fun:_ZN36PersonalDataManagerTest_Refresh_Test8TestBodyEv -} |