diff options
| author | suzhe@chromium.org <suzhe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-08 22:25:17 +0000 |
|---|---|---|
| committer | suzhe@chromium.org <suzhe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-08 22:25:17 +0000 |
| commit | db6314293da212a67c23d3cb6959572bdc4a6ae2 (patch) | |
| tree | a098ee1759ba7f18be4bf7fda940219d5d97e4a7 /tools | |
| parent | 69b04b9c7e94ab6a088cc5dde0e653223cc5e4e5 (diff) | |
| download | chromium_src-db6314293da212a67c23d3cb6959572bdc4a6ae2.zip chromium_src-db6314293da212a67c23d3cb6959572bdc4a6ae2.tar.gz chromium_src-db6314293da212a67c23d3cb6959572bdc4a6ae2.tar.bz2 | |
Move the valgrind suppression for bug 61685 to the "Can't fix" section.
By checking the source code of gtk+-2.12.x, I believe it's a bug of gtk
and should already be fixed in recent version.
See the source code of gtk+-2.12.9: http://git.gnome.org/browse/gtk+/tree/gtk/gtkimmulticontext.c?id=GTK_2_12_9#n230
global_context_id is allocated in _gtk_im_module_get_default_context_id() by calling g_strdup(), but it never gets freed.
In the latest gtk code: http://git.gnome.org/browse/gtk+/tree/gtk/gtkimmodule.c?id=2.20.1#n663
_gtk_im_module_get_default_context_id() just returns a pointer to a string literal instead of a duplicated string.
BUG=61685
TEST=none
Review URL: http://codereview.chromium.org/4715002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65441 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 29 |
1 files changed, 15 insertions, 14 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index ffa70e1..4d8b3fe 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -553,6 +553,21 @@ Memcheck:Value8 obj:/lib/libc-2.11.1.so } +{ + # I believe it's a bug in gtk+-2.12.x and should already be fixed in recent gtk. + bug_61685 + Memcheck:Leak + fun:malloc + ... + fun:gtk_text_buffer_select_range + fun:_ZN23AutocompleteEditViewGtk16SetSelectedRangeERKNS_9CharRangeE + fun:_ZN23AutocompleteEditViewGtk23SetTextAndSelectedRangeERKSbIwSt11char_traitsIwESaIwEERKNS_9CharRangeE + fun:_ZN23AutocompleteEditViewGtk24SetWindowTextAndCaretPosERKSbIwSt11char_traitsIwESaIwEEj + fun:_ZN21AutocompleteEditModel6RevertEv + fun:_ZN23AutocompleteEditViewGtk9RevertAllEv + fun:_ZN23AutocompleteEditViewGtk6UpdateEPK11TabContents + fun:_ZN15LocationBarView6UpdateEPK11TabContents +} #----------------------------------------------------------------------- # 2. intentional unit test errors, or stuff that is somehow a false positive @@ -3182,17 +3197,3 @@ fun:_ZN12_GLOBAL__N_141FormStructureTest_EncodeQueryRequest_Test8TestBodyEv fun:_ZN7testingL35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS3_FS2_vEPKc } -{ - bug_61685 - Memcheck:Leak - fun:malloc - ... - fun:gtk_text_buffer_select_range - fun:_ZN23AutocompleteEditViewGtk16SetSelectedRangeERKNS_9CharRangeE - fun:_ZN23AutocompleteEditViewGtk23SetTextAndSelectedRangeERKSbIwSt11char_traitsIwESaIwEERKNS_9CharRangeE - fun:_ZN23AutocompleteEditViewGtk24SetWindowTextAndCaretPosERKSbIwSt11char_traitsIwESaIwEEj - fun:_ZN21AutocompleteEditModel6RevertEv - fun:_ZN23AutocompleteEditViewGtk9RevertAllEv - fun:_ZN23AutocompleteEditViewGtk6UpdateEPK11TabContents - fun:_ZN15LocationBarView6UpdateEPK11TabContents -} |