diff options
| author | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 01:05:29 +0000 |
|---|---|---|
| committer | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 01:05:29 +0000 |
| commit | 43bd25e0f96c259a3dd4aeb0923ee62c236c7525 (patch) | |
| tree | d5e28fa3f58a2d288ddd9456f468c761df0334c0 /tools | |
| parent | ea84ce8e6724fc8d072a2b0016f87ef0d3771e13 (diff) | |
| download | chromium_src-43bd25e0f96c259a3dd4aeb0923ee62c236c7525.zip chromium_src-43bd25e0f96c259a3dd4aeb0923ee62c236c7525.tar.gz chromium_src-43bd25e0f96c259a3dd4aeb0923ee62c236c7525.tar.bz2 | |
Fix valgrind error in -[TabStripController layoutTabsWithAnimation:regenerateSubviews]
The error was due to the fact that I was using the return values of calls to a nil object. This is only ok for 32bit values. For things like NSRects this means that most of the NSRect is not initialized.
Fix was to check for a nil object.
BUG=77884
TEST=Reproduced the error. Verified that this change fixed the error.
Review URL: http://codereview.chromium.org/6735047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80398 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions_mac.txt | 25 |
1 files changed, 0 insertions, 25 deletions
diff --git a/tools/valgrind/memcheck/suppressions_mac.txt b/tools/valgrind/memcheck/suppressions_mac.txt index 1841946..c577532 100644 --- a/tools/valgrind/memcheck/suppressions_mac.txt +++ b/tools/valgrind/memcheck/suppressions_mac.txt @@ -1570,31 +1570,6 @@ fun:_ZN15DownloadManager24OnPathExistenceAvailableEP18DownloadCreateInfo } { - bug_77884_a - Memcheck:Cond - fun:-[TabStripController layoutTabsWithAnimation:regenerateSubviews:] - fun:-[TabStripController layoutTabs] - fun:-[TabStripController selectTabWithContents:previousContents:atIndex:userGesture:] - fun:_ZN27TabStripModelObserverBridge13TabSelectedAtEP18TabContentsWrapperS1_ib - fun:_ZN13TabStripModel26NotifyTabSelectedIfChangedEP18TabContentsWrapperib - fun:_ZN13TabStripModel19InsertTabContentsAtEiP18TabContentsWrapperi - fun:_ZN13TabStripModel17AppendTabContentsEP18TabContentsWrapperb - fun:_ZN12_GLOBAL__N_141TabStripControllerTest_AddRemoveTabs_Test8TestBodyEv -} -{ - bug_77884_b - Memcheck:Value4 - fun:_ZSt3minIfERKT_S2_S2_ - fun:-[TabStripController layoutTabsWithAnimation:regenerateSubviews:] - fun:-[TabStripController layoutTabs] - fun:-[TabStripController selectTabWithContents:previousContents:atIndex:userGesture:] - fun:_ZN27TabStripModelObserverBridge13TabSelectedAtEP18TabContentsWrapperS1_ib - fun:_ZN13TabStripModel26NotifyTabSelectedIfChangedEP18TabContentsWrapperib - fun:_ZN13TabStripModel19InsertTabContentsAtEiP18TabContentsWrapperi - fun:_ZN13TabStripModel17AppendTabContentsEP18TabContentsWrapperb - fun:_ZN12_GLOBAL__N_141TabStripControllerTest_AddRemoveTabs_Test8TestBodyEv -} -{ bug_77910 Memcheck:Leak ... |