diff options
| author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-08 07:39:08 +0000 |
|---|---|---|
| committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-02-08 07:39:08 +0000 |
| commit | 9c7132e60db51286c7499a8194c5b85a5762019b (patch) | |
| tree | 90d75d97da13e5fc9c8b03f3efee8c708e008661 /tools | |
| parent | 257493d2371e714358e1294ec390fda22a1b77c7 (diff) | |
| download | chromium_src-9c7132e60db51286c7499a8194c5b85a5762019b.zip chromium_src-9c7132e60db51286c7499a8194c5b85a5762019b.tar.gz chromium_src-9c7132e60db51286c7499a8194c5b85a5762019b.tar.bz2 | |
[Logging] Remove unneeded CheckOpString struct for CHECKs
Using string* directly works.
Made LogMessage delete any passed in string* after it uses it.
Removed suppressions for fixed memory leak.
BUG=57683
TEST=Existing unit tests
Review URL: http://codereview.chromium.org/6413032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74100 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 8 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 8 |
2 files changed, 0 insertions, 16 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index 3e04c6d..bf4ef65 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -949,14 +949,6 @@ fun:::MessageLoopRelay::ProcessOnTargetThread } { - bug_57683 - Heapcheck:Leak - ... - fun:logging::MakeCheckOpString - fun:logging::Check*Impl - fun:logging::::LoggingTest_*_Test::TestBody -} -{ bug_57799 Heapcheck:Leak fun:cricket::Transport::OnRemoteCandidate diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 6e35331..789213a 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -2872,14 +2872,6 @@ fun:_ZN14RunnableMethodIN3IPC12ChannelProxy7ContextEMS2_FvRKNS0_7MessageEE6Tuple1IS3_EE3RunEv } { - bug_57683 - Memcheck:Leak - fun:_Znw* - fun:_ZN7logging17MakeCheckOpString* - fun:_ZN7logging11Check*Impl* - fun:_ZN7logging*LoggingTest_*_Test8TestBodyEv -} -{ bug_57799 Memcheck:Leak fun:_Znw* |