diff options
| author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-30 21:28:50 +0000 |
|---|---|---|
| committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-30 21:28:50 +0000 |
| commit | 0e71026b3e6a04297c2ed1b65616e83b74508bf8 (patch) | |
| tree | 5fa5e1c3e017a45462e8b231c2820400722190e2 /tools | |
| parent | 72fda76dd8db93d169de80a7a4a47a4f1bec64e8 (diff) | |
| download | chromium_src-0e71026b3e6a04297c2ed1b65616e83b74508bf8.zip chromium_src-0e71026b3e6a04297c2ed1b65616e83b74508bf8.tar.gz chromium_src-0e71026b3e6a04297c2ed1b65616e83b74508bf8.tar.bz2 | |
Make --ignore-in-dtor=no the default ThreadSanitizer option.
My local bots (both Linux and Mac) were cycling green with this option all the last week
except for one real race (fixed tonight) and two benign reports suppressed recently.
This option will help us find more races, especially my beloved ref-counter races.
TEST=TSAN bots should remain green
Review URL: http://codereview.chromium.org/348020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30636 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/valgrind/valgrind_test.py | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py index 448965a..1c331ab 100755 --- a/tools/valgrind/valgrind_test.py +++ b/tools/valgrind/valgrind_test.py @@ -392,6 +392,9 @@ class ThreadSanitizer(ValgrindTool): parser.add_option("", "--pure-happens-before", default="yes", dest="pure_happens_before", help="Less false reports, more missed races") + parser.add_option("", "--ignore-in-dtor", default="no", + dest="ignore_in_dtor", + help="Ignore data races inside destructors") parser.add_option("", "--announce-threads", default="yes", dest="announce_threads", help="Show the the stack traces of thread creation") @@ -424,7 +427,10 @@ class ThreadSanitizer(ValgrindTool): ret += ["--file-prefix-to-cut=%s/" % self._source_dir] if self.EvalBoolFlag(self._options.pure_happens_before): - ret += ["--pure-happens-before=yes"]; + ret += ["--pure-happens-before=yes"] # "no" is the default value for TSAN + + if not self.EvalBoolFlag(self._options.ignore_in_dtor): + ret += ["--ignore-in-dtor=no"] # "yes" is the default value for TSAN if self.EvalBoolFlag(self._options.announce_threads): ret += ["--announce-threads"] |