diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-07 05:23:50 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-07 05:23:50 +0000 |
| commit | 61f25cd0eac69e1e0435e9c1875a6d92154c21e7 (patch) | |
| tree | a25d1d1235e61672c95d66a7a287cc47f175799f /tools | |
| parent | e2ce1e0bbcc8f4336770a28107daff34a68514db (diff) | |
| download | chromium_src-61f25cd0eac69e1e0435e9c1875a6d92154c21e7.zip chromium_src-61f25cd0eac69e1e0435e9c1875a6d92154c21e7.tar.gz chromium_src-61f25cd0eac69e1e0435e9c1875a6d92154c21e7.tar.bz2 | |
Revert 65329 - Revert 65272 - Autofill heapcheck and valgrind leak in PersonalDataManager unit test fixed
[Redness was not healed... so I'm reverting the revert]
An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test. This fixes it. Also, some small cleanup in the test itself.
BUG=61988
TEST=Memory bots stay green.
Review URL: http://codereview.chromium.org/4612001
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/4641001
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/4643001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65330 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 12 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 14 |
2 files changed, 0 insertions, 26 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index a5c1b0f..cb0d582 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1053,15 +1053,3 @@ fun:testing::HandleExceptionsInMethodIfSupported fun:testing::Test::Run } -{ - bug_61988_a - Heapcheck:Leak - ... - fun:PersonalDataManagerTest_Refresh_Test::TestBody -} -{ - bug_61988_b - Heapcheck:Leak - ... - fun:TestingProfile::CreateWebDataService -} diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 3bd23e8..ffa70e1 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -3196,17 +3196,3 @@ fun:_ZN23AutocompleteEditViewGtk6UpdateEPK11TabContents fun:_ZN15LocationBarView6UpdateEPK11TabContents } -{ - bug_61988_a - Memcheck:Leak - fun:_Znw* - ... - fun:_ZN14TestingProfile20CreateWebDataServiceEb - fun:_ZN23PersonalDataManagerTest5SetUpEv -} -{ - bug_61988_b - Memcheck:Leak - ... - fun:_ZN36PersonalDataManagerTest_Refresh_Test8TestBodyEv -} |