diff options
| author | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-28 13:15:27 +0000 |
|---|---|---|
| committer | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-28 13:15:27 +0000 |
| commit | cb9bf6ca4df8e780915af41d76aa044dd6fc7c7e (patch) | |
| tree | e7d6c825bfb3b7d54f773ec010915dd7c99227a4 /tools | |
| parent | ed70a4b559a6968519187238181eee9ef184e010 (diff) | |
| download | chromium_src-cb9bf6ca4df8e780915af41d76aa044dd6fc7c7e.zip chromium_src-cb9bf6ca4df8e780915af41d76aa044dd6fc7c7e.tar.gz chromium_src-cb9bf6ca4df8e780915af41d76aa044dd6fc7c7e.tar.bz2 | |
The HttpRequestInfo object must outlive the HttpNetworkTransaction object because HttpRequestInfo is passed to HttpNetworkTransaction::Start() and HttpNetworkTransaction access the request info object in many places.
With the current code UploadData gets deleted before HttpStreamParser and that causes
read-after-free cases as shown in the below bug.
BUG=70825
TEST=verify that the valgrind issue mentioned in the bug gets fixed
Review URL: http://codereview.chromium.org/6327020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72954 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 661e9d1..d602a31 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -3644,22 +3644,6 @@ fun:_ZN9talk_base6Thread15ProcessMessagesEi } { - bug_70825 - Memcheck:Addr1 - fun:_ZNK3net10UploadData10is_chunkedEv - fun:_ZNK3net16UploadDataStream10is_chunkedEv - fun:_ZN3net16HttpStreamParserD0Ev - ... - fun:_ZN10scoped_ptrIN3net16HttpStreamParserEED1Ev - fun:_ZN3net15HttpBasicStreamD0Ev - ... - fun:_ZN10scoped_ptrIN3net10HttpStreamEED1Ev - fun:_ZN3net22HttpNetworkTransactionD0Ev - ... - fun:_ZN10scoped_ptrIN3net15HttpTransactionEED1Ev - fun:_ZN3net42HttpNetworkTransactionTest_Ignores100_Test8TestBodyEv -} -{ bug_70924_a Memcheck:Leak fun:_Znw* |