diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-07 04:10:11 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-11-07 04:10:11 +0000 |
| commit | e2ce1e0bbcc8f4336770a28107daff34a68514db (patch) | |
| tree | 0a2a9e66f524f9354c4031f28fbbf99c33e152ae /tools | |
| parent | 7e7fab44ba1068bdce201757e82b6650fbca455d (diff) | |
| download | chromium_src-e2ce1e0bbcc8f4336770a28107daff34a68514db.zip chromium_src-e2ce1e0bbcc8f4336770a28107daff34a68514db.tar.gz chromium_src-e2ce1e0bbcc8f4336770a28107daff34a68514db.tar.bz2 | |
Revert 65272 - Autofill heapcheck and valgrind leak in PersonalDataManager unit test fixed
[There is a lot of red on valgrind now... so trying a revert]
An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test. This fixes it. Also, some small cleanup in the test itself.
BUG=61988
TEST=Memory bots stay green.
Review URL: http://codereview.chromium.org/4612001
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/4641001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65329 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 12 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 14 |
2 files changed, 26 insertions, 0 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index cb0d582..a5c1b0f 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1053,3 +1053,15 @@ fun:testing::HandleExceptionsInMethodIfSupported fun:testing::Test::Run } +{ + bug_61988_a + Heapcheck:Leak + ... + fun:PersonalDataManagerTest_Refresh_Test::TestBody +} +{ + bug_61988_b + Heapcheck:Leak + ... + fun:TestingProfile::CreateWebDataService +} diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index ffa70e1..3bd23e8 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -3196,3 +3196,17 @@ fun:_ZN23AutocompleteEditViewGtk6UpdateEPK11TabContents fun:_ZN15LocationBarView6UpdateEPK11TabContents } +{ + bug_61988_a + Memcheck:Leak + fun:_Znw* + ... + fun:_ZN14TestingProfile20CreateWebDataServiceEb + fun:_ZN23PersonalDataManagerTest5SetUpEv +} +{ + bug_61988_b + Memcheck:Leak + ... + fun:_ZN36PersonalDataManagerTest_Refresh_Test8TestBodyEv +} |