summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authordarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-02 19:23:45 +0000
committerdarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-02 19:23:45 +0000
commit15d79e12a0831ac527dc938297c14a386dcf5f0a (patch)
tree22c72b70cd8d4534433a1005b5e680c66eeb9463 /tools
parent30de967447ec9f048578cda8b22aba5fad2c68d8 (diff)
downloadchromium_src-15d79e12a0831ac527dc938297c14a386dcf5f0a.zip
chromium_src-15d79e12a0831ac527dc938297c14a386dcf5f0a.tar.gz
chromium_src-15d79e12a0831ac527dc938297c14a386dcf5f0a.tar.bz2
Move alternate error page loading out of WebFrame.
Make the RenderView be in charge of loading alternate error pages. While working on this change, I noticed several related bugs: 1- Loading an URL with an invalid host name from the new tab page results in an error page. If you hit back and then forward, you will be left with an empty location bar. In a debug build this trips an assertion in ClassifyNavigation because the given page_id is -1. This problem is caused by not duplicating the NavigationState of the failed load when creating a load for the error page. Hence, the pending_page_id of the forward navigation is lost. 2- Loading an URL with an invalid host name as a subframe results in an extra navigation in session history. One navigation for the main frame and one navigation for the error page load. This is another symptom of the problem described in #1. However, the solution is different. Here, we need to know that the subframe load is an AUTO_SUBFRAME load so that we load the error page using 'replace' semantics (so that WebCore does not generate a new session history entry). Finally, I decided to restrict alternative DNS error pages to only work for the main frame to match what we do for alternative 404 error pages. It doesn't seem worth it to show link doctor results for subframes since their primary purpose is to assist people who mis-type an URL. R=tony,brettw BUG=15648 TEST=covered by errorpage_uitest.cc Review URL: http://codereview.chromium.org/159575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22253 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions