diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-25 00:17:53 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-25 00:17:53 +0000 |
| commit | 3c4e3015463fd407ccd932e5da17e3c4bc8e3c5c (patch) | |
| tree | 0d9eb8dc82e0514d1b77943bb452b75396f18dea /tools | |
| parent | f820596a817c435611567e5131709162bfb6cfad (diff) | |
| download | chromium_src-3c4e3015463fd407ccd932e5da17e3c4bc8e3c5c.zip chromium_src-3c4e3015463fd407ccd932e5da17e3c4bc8e3c5c.tar.gz chromium_src-3c4e3015463fd407ccd932e5da17e3c4bc8e3c5c.tar.bz2 | |
Enable TCMalloc on Linux by default.
This change also reworks the tcmalloc dependency to be added only to chrome and test_shell, instead of base. This is necessary since otherwise tcmalloc will be double initialized (by both the main executable and dlopen'd shared objects like the npapitestplugin.so).
Add valgrind suppressions. This are invalid reads on static initialization in the VDSOSupport module. I haven't investigated it yet, but I suspect they're benign.
BUG=http://crbug.com/28149, http://crbug.com/28385
Review URL: http://codereview.chromium.org/399081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33010 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 9270036..9a773e4 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -346,6 +346,32 @@ ... obj:/bin/ps } +{ + # Valgrind issues with tcmalloc's VDSOSupport module + bug_28149a + Memcheck:Addr1 + fun:_ZN4base11VDSOSupport11ElfMemImage4InitEPKv + fun:_ZN4base11VDSOSupport11ElfMemImageC1EPKv + fun:_ZN4base11VDSOSupportC1Ev + fun:_ZN4base11VDSOSupport4InitEv + fun:_ZN4base14VDSOInitHelperC1Ev + fun:_Z41__static_initialization_and_destruction_0ii + fun:_GLOBAL__I__ZN4base11VDSOSupport12kInvalidBaseE + obj:/b/slave/webkit-rel-linux-valgrind-layout/build/src/sconsbuild/Release/test_shell + obj:/b/slave/webkit-rel-linux-valgrind-layout/build/src/sconsbuild/Release/test_shell + fun:__libc_csu_init + fun:(below main) +} +{ + # Valgrind issues with tcmalloc's VDSOSupport module + bug_28149b + Memcheck:Addr4 + ... + fun:_ZNK4base11VDSOSupport12LookupSymbolEPKcS2_iPNS0_10SymbolInfoE + ... + fun:_Z41__static_initialization_and_destruction_0ii + ... +} #----------------------------------------------------------------------- # 2. intentional unit test errors, or stuff that is somehow a false positive |