diff options
| author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-02 19:01:48 +0000 |
|---|---|---|
| committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-02 19:01:48 +0000 |
| commit | 8470f4693faac244f839c38358512244b47cb680 (patch) | |
| tree | 0da2af36d2a073dd23520801539293d64ea4987a /tools | |
| parent | 270e8dc3c85612611354a7d616d51216e8725610 (diff) | |
| download | chromium_src-8470f4693faac244f839c38358512244b47cb680.zip chromium_src-8470f4693faac244f839c38358512244b47cb680.tar.gz chromium_src-8470f4693faac244f839c38358512244b47cb680.tar.bz2 | |
Split a portion of BufferedResourceLoader into a separate class ActiveLoader.
ActiveLoader encapsulates an active WebURLLoader and takes care of maintaining deferred status, references to parent object, and automatic cancelation during teardown.
As a result of fixing the imbalanced reference counts to BufferedResourceLoader there were a few use-after-free bugs due to doing work after executing callbacks. The ordering has been updated to ensure that no more work is done after executing callbacks.
BUG=100914
Review URL: http://codereview.chromium.org/8667002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112747 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 25 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 12 |
2 files changed, 0 insertions, 37 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index b31b0bd..fa90381 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1772,30 +1772,6 @@ fun:ProfileSyncService::Shutdown } { - bug_100914_a - Heapcheck:Leak - ... - fun:webkit_media::MockBufferedDataSource::CreateMockResourceLoader -} -{ - bug_100914_b - Heapcheck:Leak - ... - fun:BufferedDataSourceTest -} -{ - bug_100914_c - Heapcheck:Leak - ... - fun:webkit_media::BufferedDataSourceTest::Initialize -} -{ - bug_100914_d - Heapcheck:Leak - fun:webkit_media::MockBufferedDataSource::MockBufferedDataSource - fun:webkit_media::BufferedDataSourceTest::BufferedDataSourceTest -} -{ bug_106109 Heapcheck:Leak ... @@ -1809,4 +1785,3 @@ fun:AccessibilityEventRouterViewsTest::CreateWindowWithContents fun:AccessibilityEventRouterViewsTest_TestFocusNotification_Test::TestBody } - diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index ab743f47..389ee6a 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -4534,18 +4534,6 @@ fun:_ZN16CrxUpdateService19ProcessPendingItemsEv } { - bug_100914_a - Memcheck:Leak - fun:_Znw* - fun:_ZN12webkit_media18BufferedDataSource20CreateResourceLoaderEll -} -{ - bug_100914_b - Memcheck:Leak - ... - fun:_ZN12webkit_media22MockBufferedDataSource24CreateMockResourceLoaderE?? -} -{ bug_100916 Memcheck:Leak fun:_Znw* |