summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-20 13:26:17 +0000
committerthomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-20 13:26:17 +0000
commit592cd6e40002699640e63d53d5b6604ce595deca (patch)
tree8364da09d754e5c46f9e0702453e486a498ce0a4 /tools
parent2f1bc799ca278fdcfe316246d79c0153aff65122 (diff)
downloadchromium_src-592cd6e40002699640e63d53d5b6604ce595deca.zip
chromium_src-592cd6e40002699640e63d53d5b6604ce595deca.tar.gz
chromium_src-592cd6e40002699640e63d53d5b6604ce595deca.tar.bz2
Add a linux suppressions file to handle the linux specific leaks.
Add the pattern for the mac leak. Add the pattern for the linux leak. TBR=mmoss TEST=none BUG=42084 Review URL: http://codereview.chromium.org/1677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45030 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/valgrind/memcheck/suppressions_linux.txt36
-rw-r--r--tools/valgrind/memcheck/suppressions_mac.txt18
2 files changed, 54 insertions, 0 deletions
diff --git a/tools/valgrind/memcheck/suppressions_linux.txt b/tools/valgrind/memcheck/suppressions_linux.txt
new file mode 100644
index 0000000..94a8f5f
--- /dev/null
+++ b/tools/valgrind/memcheck/suppressions_linux.txt
@@ -0,0 +1,36 @@
+# There are three kinds of suppressions in this file:
+# 1. Third party stuff we have no control over.
+#
+# 2. Intentional unit test errors, stuff that is somehow a false positive
+# in our own code, or stuff that is so trivial it's not worth fixing.
+#
+# 3. Suppressions for real chromium bugs that are not yet fixed.
+# These should all be in chromium's bug tracking system.
+# Periodically we should sweep this file and the bug tracker clean by
+# running overnight and removing outdated bugs/suppressions.
+#-----------------------------------------------------------------------
+
+# 1. Third party stuff we have no control over.
+
+
+# 2. Intentional unit test errors, stuff that is somehow a false positive
+# in our own code, or stuff that is so trivial it's not worth fixing.
+
+
+# 3. Suppressions for real chromium bugs that are not yet fixed.
+{
+ # ChromeOS and Linux version have slightly different signatures, hence the
+ # wildcard on part.
+ bug_42084
+ Memcheck:Leak
+ fun:_Znw*
+ fun:_ZN3net62_GLOBAL__N_net_spdy_spdy_session_unittest.cc_00000000*
+ fun:_ZN3net62_GLOBAL__N_net_spdy_spdy_session_unittest.cc_00000000*
+ fun:_ZN7testing4Test3RunEv
+ fun:_ZN7testing8internal12TestInfoImpl3RunEv
+ fun:_ZN7testing8TestCase3RunEv
+ fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
+ fun:_ZN7testing8UnitTest3RunEv
+ fun:_ZN9TestSuite3RunEv
+ fun:main
+}
diff --git a/tools/valgrind/memcheck/suppressions_mac.txt b/tools/valgrind/memcheck/suppressions_mac.txt
index e8defbc..8a27ae6 100644
--- a/tools/valgrind/memcheck/suppressions_mac.txt
+++ b/tools/valgrind/memcheck/suppressions_mac.txt
@@ -1024,3 +1024,21 @@
fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE
fun:_ZN11MessageLoop11RunInternalEv
}
+{
+ # The two patterns differ only in one frame:
+ # fun:_ZN3net15SpdySessionPool14AddSessionListERKNS_12HostPortPairE
+ # so include '...' to handle that.
+ bug_42084
+ Memcheck:Leak
+ fun:_Znw*
+ ...
+ fun:_ZN3net15SpdySessionPool3GetERKNS_12HostPortPairEPNS_18HttpNetworkSessionE
+ fun:_ZN3net12_GLOBAL__N_127SpdySessionTest_GoAway_Test8TestBodyEv
+ fun:_ZN7testing4Test3RunEv
+ fun:_ZN7testing8internal12TestInfoImpl3RunEv
+ fun:_ZN7testing8TestCase3RunEv
+ fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
+ fun:_ZN7testing8UnitTest3RunEv
+ fun:_ZN9TestSuite3RunEv
+ fun:main
+}