diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-01 17:22:30 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-01 17:22:30 +0000 |
| commit | b797b3d9bb65fa682dc79cdbaa8374e5faf36758 (patch) | |
| tree | 5575da69686d424c009c998c11d9a76c66e92519 /tools | |
| parent | 32bb8540347359ac40ac53e06089cbdc1db0a532 (diff) | |
| download | chromium_src-b797b3d9bb65fa682dc79cdbaa8374e5faf36758.zip chromium_src-b797b3d9bb65fa682dc79cdbaa8374e5faf36758.tar.gz chromium_src-b797b3d9bb65fa682dc79cdbaa8374e5faf36758.tar.bz2 | |
Try to bandaid leaks due to TabContentsWrapper not force-closing all InfoBarDelegates on shutdown. The real fix will come when changing to the newer ownership model, when TCW can CloseSoon() Infobars directly, but for now, manually close things in a couple places.
Also makes a few other tiny changes to bring the code yet closer to my final-form checkout.
BUG=87998
TEST=none
Review URL: http://codereview.chromium.org/7294006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91316 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 28 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 7 |
2 files changed, 0 insertions, 35 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index be2f8bd..5b35071 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1602,31 +1602,3 @@ ... fun:content_settings::PrefProviderTest_MigrateSinglePatternSettings_Test::TestBody } -{ - bug_87998_a - Heapcheck:Leak - ... - fun:bool ::InitCanonical - fun:GURL::GURL - fun:GeolocationPermissionContextTests*::TestBody -} -{ - bug_87998_b - Heapcheck:Leak - ... - fun:GeolocationInfoBarQueueController::CreateInfoBarRequest - fun:ChromeGeolocationPermissionContext::RequestGeolocationPermission - fun:GeolocationPermissionContextTests*::TestBody -} -{ - bug_87998_c - Heapcheck:Leak - ... - fun:TestingProfile::GetPrefs - fun:AutocompleteHistoryManager::AutocompleteHistoryManager - fun:TabContentsWrapper::TabContentsWrapper - fun:TabContentsWrapperTestHarness::SetContents - fun:TabContentsWrapperTestHarness::SetUp - fun:GeolocationPermissionContextTests::SetUp -} - diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index bc9df60..44ab0a5 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -4801,13 +4801,6 @@ fun:_ZN8chromeos12input_method18InputMethodManager11GetInstanceEv } { - bug_87998 - Memcheck:Leak - fun:_Znw* - fun:_ZN33GeolocationInfoBarQueueController17ShowQueuedInfoBarEii - fun:_ZN33GeolocationInfoBarQueueController20CreateInfoBarRequestEiiiRK4GURLS2_ - fun:_ZN34ChromeGeolocationPermissionContext28RequestGeolocationPermissionEiiiRK4GURL -} #----------------------------------------------------------------------- # These only occur on our Google workstations |