summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-21 01:21:43 +0000
committerestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-21 01:21:43 +0000
commit4b32fe696f8a3b84a4feb16f1ce8dfa5d5f41a9a (patch)
tree98098331aec7763d892ea1def2a2ec90d09b3e55 /tools
parent2d8bfca747e386fd929c57e014e227b148ac2142 (diff)
downloadchromium_src-4b32fe696f8a3b84a4feb16f1ce8dfa5d5f41a9a.zip
chromium_src-4b32fe696f8a3b84a4feb16f1ce8dfa5d5f41a9a.tar.gz
chromium_src-4b32fe696f8a3b84a4feb16f1ce8dfa5d5f41a9a.tar.bz2
Info bubble focus tweaks.
We can't close info bubbles when they lose focus because then we can't use the select dropdown in the bookmark bubble. Thus we have to watch the active window. Since we are doing this, we no longer need the application level grab or the button press handler. This also fixes the problem that a browser window showing an info bubble will paint inactive (assuming your WM supports active/inactive windows). This maintains the desirable properties: - info bubbles close when you click outside them but inside the parent window - info bubbles close when the parent window closes - info bubbles don't show up on alternate desktops (even if your WM doesn't support active/inactive windows) - info bubbles can survive losing focus to a popup window This breaks the desirable properties: - clicking on something in the browser while the info bubble is showing both dismisses the info bubble and does the appropriate action in the browser - the info bubble dismisses when the browser loses focus in a window manager that doesn't support active/inactive state - on xmonad, if you have the cursor over the browser window but the focus is on the info bubble (this is hard to do, since focus is supposed to follow the mouse, but not impossible), then it requires two clicks to dismiss the info bubble. But I think that this is a problem with xmonad and is present before this patch as well. So this is not the best of all possible worlds, but it is an improvement over our current state as well as an improvement over the state before r20977. BUG=17223 TEST=browser doesn't crash when you open the select dropdown in the bookmark bubble Review URL: http://codereview.chromium.org/155793 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21141 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions