summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authortimurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-08 10:02:03 +0000
committertimurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-11-08 10:02:03 +0000
commit6a5d838e180cc6fc9f26b4ab9c2e09f033b6a4aa (patch)
treec9f3a3e65c29d19f2adc2c20d36023eedbf0bc34 /tools
parent57a31b1594f49ebfb77d2cce0190c4db0f60bcd6 (diff)
downloadchromium_src-6a5d838e180cc6fc9f26b4ab9c2e09f033b6a4aa.zip
chromium_src-6a5d838e180cc6fc9f26b4ab9c2e09f033b6a4aa.tar.gz
chromium_src-6a5d838e180cc6fc9f26b4ab9c2e09f033b6a4aa.tar.bz2
Use less TSan ignores for base/atomic*
TEST=TSan bots on the memory waterfall should remain green Review URL: http://codereview.chromium.org/4671001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65357 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/valgrind/tsan/ignores.txt5
-rw-r--r--tools/valgrind/tsan/ignores_mac.txt6
2 files changed, 4 insertions, 7 deletions
diff --git a/tools/valgrind/tsan/ignores.txt b/tools/valgrind/tsan/ignores.txt
index 2128996..5f32517 100644
--- a/tools/valgrind/tsan/ignores.txt
+++ b/tools/valgrind/tsan/ignores.txt
@@ -53,12 +53,15 @@ src:*ts_valgrind_intercepts.c
##################################################################
# Don't instrument synchronization code
src:*base/waitable_event*
-src:*base/atomic*
src:*base/condition_variable*
src:*base/lock*
src:*base/stats_counters*
src:*base/thread_local_storage*
+# Don't instrument code dealing with atomics (base::subtle)
+fun:*base*subtle*Release_Store*
+fun:*base*subtle*NoBarrier_CompareAndSwap*
+
# Don't instrument tcmalloc
src:*/tcmalloc/*
diff --git a/tools/valgrind/tsan/ignores_mac.txt b/tools/valgrind/tsan/ignores_mac.txt
index 20c7a13..2b8e778 100644
--- a/tools/valgrind/tsan/ignores_mac.txt
+++ b/tools/valgrind/tsan/ignores_mac.txt
@@ -4,12 +4,6 @@
# ThreadSanitizer, so we have to define fun:* rules for Mac OS complementing
# the src:* rules defined for Linux.
-# Don't instrument code dealing with atomics (base::subtle)
-fun:*base*subtle*NoBarrier_Load*
-fun:*base*subtle*Release_Store*
-fun:*base*subtle*NoBarrier_Store*
-fun:*base*subtle*NoBarrier_CompareAndSwap*
-
# we ignore the Security libraries for now since
# their instrumentation is very slow.
# TODO(timurrrr): investigate whether we need to instrument them