diff options
| author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-19 19:54:42 +0000 |
|---|---|---|
| committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-19 19:54:42 +0000 |
| commit | a4dd0a8fe88767a19282752c4d96c35f1a968fdd (patch) | |
| tree | a27c710433b7fe66407fe8c9734953630726f6aa /tools | |
| parent | d4765fec57e624dfae0205bef9ce8b4ccc6b9baf (diff) | |
| download | chromium_src-a4dd0a8fe88767a19282752c4d96c35f1a968fdd.zip chromium_src-a4dd0a8fe88767a19282752c4d96c35f1a968fdd.tar.gz chromium_src-a4dd0a8fe88767a19282752c4d96c35f1a968fdd.tar.bz2 | |
Ignore accesses below ChromeThread::GetCurrentThreadIdentifier
BUG=44580
TBR=cbentzel,glider
Review URL: http://codereview.chromium.org/2092016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47707 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/tsan/ignores.txt | 5 | ||||
| -rw-r--r-- | tools/valgrind/tsan/suppressions.txt | 14 |
2 files changed, 5 insertions, 14 deletions
diff --git a/tools/valgrind/tsan/ignores.txt b/tools/valgrind/tsan/ignores.txt index 529bc35..378d14c 100644 --- a/tools/valgrind/tsan/ignores.txt +++ b/tools/valgrind/tsan/ignores.txt @@ -83,3 +83,8 @@ fun:*icu_4_2*UnicodeSet*add* # There's some weird failure test going on in this tiny test function in sqlite fun_r:threadLockingTest + +# Ignore accesses below GetCurrentThreadIdentifier. +# There is a benign race which is hard to suppress properly, +# see http://crbug.com/44580 +fun_r:*ChromeThread*GetCurrentThreadIdentifier* diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt index ccb69f8..7e96151 100644 --- a/tools/valgrind/tsan/suppressions.txt +++ b/tools/valgrind/tsan/suppressions.txt @@ -26,20 +26,6 @@ fun:*browser_sync*SyncShareIntercept*Observe* } -# The race happens during enumeration of ChromeThreads. -# For each ChromeThread we check whether its message_loop() -# equals MessageLoop::current(). -# The race can happen if one of the ChromeThreads is exiting. -# This is benign since current thread can't exit while we -# execute GetCurrentThreadIdentifier() and other message_loops -# won't match the current one anyway. -{ - Benign race under ChromeThread::GetCurrentThreadIdentifier - ThreadSanitizer:Race - fun:*base*Thread*message_loop* - fun:*ChromeThread*GetCurrentThreadIdentifier* -} - ############################ # Real races in third_party { |