diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-31 22:36:21 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-31 22:36:21 +0000 |
| commit | b2a9bbd42c6d5215c43067582fa2bca3cfc5e20e (patch) | |
| tree | 3a19dea8153c354505ede0d67f4dd20fb03c4326 /tools | |
| parent | daf82f8e54e875ad6e97aef6952ef181de65caeb (diff) | |
| download | chromium_src-b2a9bbd42c6d5215c43067582fa2bca3cfc5e20e.zip chromium_src-b2a9bbd42c6d5215c43067582fa2bca3cfc5e20e.tar.gz chromium_src-b2a9bbd42c6d5215c43067582fa2bca3cfc5e20e.tar.bz2 | |
Enable tracking of objects by default
This is a reland of accumulated patches including CLs
8414036, 8425010, 8425013, 8424013.
It fully enables tracking of objects, as seen in about:tracking
in teh release build.
The problem this had in its initaial landing centered on
Mac instability in base_unittest. We were encountering crash
on exit of the tests, with a stack dump involving pthreads.
r=rtenneti
BUG=101856
Review URL: http://codereview.chromium.org/8429009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108026 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 17 | ||||
| -rw-r--r-- | tools/valgrind/tsan/suppressions_mac.txt | 7 |
2 files changed, 24 insertions, 0 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index 5fa51dd..08cfe7d 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -193,6 +193,23 @@ fun:base::LeakyLazyInstanceTraits::New fun:base::LazyInstance::Pointer } +{ + Intentional leak in object tracking statics to avoid shutdown race + Heapcheck:Leak + ... + fun:tracked_objects::ThreadData::Initialize* +} +{ + Intentional leak in object tracking of thread context to avoid shutdown race + Heapcheck:Leak + fun:tracked_objects::ThreadData::Get +} +{ + Intentional leak of task birth and death data to avoid shutdown race + Heapcheck:Leak + ... + fun:tracked_objects::ThreadData::TallyA* +} #----------------------------------------------------------------------- diff --git a/tools/valgrind/tsan/suppressions_mac.txt b/tools/valgrind/tsan/suppressions_mac.txt index 88d5c46..97336f2 100644 --- a/tools/valgrind/tsan/suppressions_mac.txt +++ b/tools/valgrind/tsan/suppressions_mac.txt @@ -167,6 +167,13 @@ fun:base::SharedMemory::CreateNamed } +{ + Benign race to access status during TrackedObject unittests + ThreadSanitizer:Race + ... + fun:tracked_objects::ThreadData::ShutdownSingleThreadedCleanup +} + #----------------------------------------------------------------------- # 3. Suppressions for real chromium bugs that are not yet fixed. # These should all be in chromium's bug tracking system (but a few aren't yet). |