diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-10 00:30:09 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-10 00:30:09 +0000 |
| commit | c5e8b5bf0d3cf1b5fc1ddd1369e47f620d4a135f (patch) | |
| tree | 02739809f89fb71e6a81db6fc8553e25532a9e6e /tools | |
| parent | 6ec18e6aaa37da728f98c31721fffa77ccb45407 (diff) | |
| download | chromium_src-c5e8b5bf0d3cf1b5fc1ddd1369e47f620d4a135f.zip chromium_src-c5e8b5bf0d3cf1b5fc1ddd1369e47f620d4a135f.tar.gz chromium_src-c5e8b5bf0d3cf1b5fc1ddd1369e47f620d4a135f.tar.bz2 | |
Fix memory leak in sync notifier unit tests
When XmppConnection is deleted, its TaskPump member is not deleted immediately.
The destructor equeues a task to the message loop to have it deleted later. A
comment in ~XmppConnection that explains why it does this.
In the unit tests, the TaskPump would get leaked because the message loop would
never get a chance to run that deletion task. This commit fixes the problem
by running all pending tasks on that message loop before we exit the test.
BUG=80238,79651
TEST=InvalidationNotifierTest
Review URL: http://codereview.chromium.org/7863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100542 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index 6e78894..915e4eb 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1165,20 +1165,6 @@ fun:browser_sync::SyncerThread::DoSyncSessionJob } { - bug_79651_a - Heapcheck:Leak - ... - fun:sync_notifier::InvalidationNotifier::UpdateCredentials - fun:sync_notifier::::InvalidationNotifierTest_Basic_Test::TestBody -} -{ - bug_79651_b - Heapcheck:Leak - ... - fun:*basic_string* - fun:sync_notifier::::InvalidationNotifierTest_Basic_Test::TestBody -} -{ bug_80196 Heapcheck:Leak fun:CallbackRunner* NewCallback @@ -1188,12 +1174,6 @@ fun:browser_sync::DataTypeManagerImpl::Configure } { - bug_80238 - Heapcheck:Leak - ... - fun:sync_notifier::::InvalidationNotifierTest::SetUp -} -{ bug_80467 Heapcheck:Leak ... @@ -1224,17 +1204,6 @@ fun:RenderWidgetHost::WasHidden } { - bug_79651 - Heapcheck:Leak - ... - fun:TestURLRequestContextGetter::GetURLRequestContext - fun:*SingleLoginAttempt - fun:notifier::Login::StartConnection - fun:sync_notifier::InvalidationNotifier::UpdateCredentials - fun:sync_notifier::NonBlockingInvalidationNotifier::Core::UpdateCredentials - fun:void DispatchToMethod -} -{ bug_80654 Heapcheck:Leak fun:__gnu_cxx::new_allocator::allocate |