diff options
| author | dank@chromium.org <dank@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-23 00:53:52 +0000 |
|---|---|---|
| committer | dank@chromium.org <dank@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-23 00:53:52 +0000 |
| commit | 077bfe3dfb2f1b1bf5f5656411e918cee3941dc8 (patch) | |
| tree | d1afaa839737487cb658b72a74f0266769796b35 /tools | |
| parent | f20920fc7d56aebfd9631318c2b0d1adf36c5a9e (diff) | |
| download | chromium_src-077bfe3dfb2f1b1bf5f5656411e918cee3941dc8.zip chromium_src-077bfe3dfb2f1b1bf5f5656411e918cee3941dc8.tar.gz chromium_src-077bfe3dfb2f1b1bf5f5656411e918cee3941dc8.tar.bz2 | |
Don't kill dsymutil after it finishes.
BUG=17441
TEST=sh tools/valgrind/chrome_test.sh -t ui on mac, watch it not time out when running dsymutil
Review URL: http://codereview.chromium.org/159196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21361 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/valgrind/valgrind_test.py | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py index 9409fcd..b4a702d 100755 --- a/tools/valgrind/valgrind_test.py +++ b/tools/valgrind/valgrind_test.py @@ -185,9 +185,11 @@ class ValgrindTool(object): dsymutil_command = ['dsymutil', test_command] - # dsymutil is crazy slow. Let it run for up to a half hour. I hope - # that's enough. - common.RunSubprocess(dsymutil_command, 30 * 60) + # dsymutil is crazy slow. Ideally we'd have a timeout here, + # but common.RunSubprocess' timeout is only checked + # after each line of output; dsymutil is silent + # until the end, and is then killed, which is silly. + common.RunSubprocess(dsymutil_command) if saved_test_command: os.rename(saved_test_command, test_command) |