diff options
| author | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-20 20:02:16 +0000 |
|---|---|---|
| committer | sergeyu@chromium.org <sergeyu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-20 20:02:16 +0000 |
| commit | 57d70683af99e601abb08f68651b873d74099475 (patch) | |
| tree | 46bad19ff6f050e2fffb35cac227309a7d16c3f2 /tools | |
| parent | ec3fd91aaddbb5c49f407466e8561aa4c1abbb9d (diff) | |
| download | chromium_src-57d70683af99e601abb08f68651b873d74099475.zip chromium_src-57d70683af99e601abb08f68651b873d74099475.tar.gz chromium_src-57d70683af99e601abb08f68651b873d74099475.tar.bz2 | |
Remove suppressions for bug 222601.
The warning was caused by race inside XFixes when running
ScreenCaptureDeviceTest and ScreenCapturerTest. ScreenCapturerDevice uses
XFixes on a parallel thread that later competes with ScreenCapturerTest.
The failure doesn't happen anymore because the tests have been moved to
different locations (content and webrtc), so the suppressions are not
needed anymore.
It's not completely clear what causes the failure in the first place.
XextFindDisplay() seems to be thread-safe (
http://cvsweb.xfree86.org/cvsweb/*checkout*/xc/lib/Xext/extutil.c?rev=1.8
) - it locks _Xglocal_lock before accessing global values.
BUG=222601
R=wez@chromium.org
Review URL: https://codereview.chromium.org/17412011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207522 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/tsan/suppressions.txt | 26 |
1 files changed, 0 insertions, 26 deletions
diff --git a/tools/valgrind/tsan/suppressions.txt b/tools/valgrind/tsan/suppressions.txt index 5d0d847..3465eb3 100644 --- a/tools/valgrind/tsan/suppressions.txt +++ b/tools/valgrind/tsan/suppressions.txt @@ -1067,32 +1067,6 @@ fun:base::debug::TraceSamplingThread::ThreadMain } { - bug_222601a - ThreadSanitizer:Race - fun:XFixesFindDisplay - fun:XFixesQueryExtension - fun:media::::ScreenCapturerLinux::Init -} -{ - bug_222601b - ThreadSanitizer:Race - fun:XextFindDisplay - ... - fun:XShmQueryVersion - fun:media::XServerPixelBuffer::InitShm - fun:media::XServerPixelBuffer::Init - fun:media::::ScreenCapturerLinux::Init -} -{ - bug_222601c - ThreadSanitizer:Race - fun:XextAddDisplay - ... - fun:media::XServerPixelBuffer::InitShm - fun:media::XServerPixelBuffer::Init - fun:media::::ScreenCapturerLinux::Init -} -{ bug_222684a ThreadSanitizer:Race ... |