Suppress all reports from waterfall_drmem.sh.

Also fix test_suppressions.py for drmemory bots, which also match "Windows%20".

R=timurrrr@chromium.org
BUG=74417,32624
TEST=waterfall_drmem.sh

Review URL: https://chromiumcodereview.appspot.com/9323045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121243 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 98 insertions, 25 deletions

diff --git a/tools/valgrind/drmemory/suppressions_full.txt b/tools/valgrind/drmemory/suppressions_full.txt
index 0073c0e..040c796 100644
--- a/tools/valgrind/drmemory/suppressions_full.txt
+++ b/tools/valgrind/drmemory/suppressions_full.txt
@@ -351,6 +351,13 @@ name=http://code.google.com/p/drmemory/issues/detail?id=412 g
 ...
 *!SymmetricKeyTest_ImportGeneratedKey_Test::TestBody
 
+# We get these sometimes from AesEncrypt and AesExpandKey.  AesEncrypt doesn't
+# have frame pointers, and we have trouble unwinding from it.  Therefore, we use
+# this broad suppression, effectively disabling uninit checks in rsaenh.dll.
+UNINITIALIZED READ
+name=http://code.google.com/p/drmemory/issues/detail?id=712 h
+RSAENH.dll!*
+
 UNINITIALIZED READ
 name=http://code.google.com/p/drmemory/issues/detail?id=425 a
 CLBCatQ.DLL!DestroyStgDatabase
@@ -438,6 +445,13 @@ iphlpapi.dll!GetPerAdapterInfo
 ...
 iphlpapi.dll!GetAdaptersAddresses
 
+POSSIBLE LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=473 c
+RPCRT4.dll!*
+RPCRT4.dll!*
+...
+IPHLPAPI.DLL!GetAdaptersAddresses
+
 LEAK
 name=http://code.google.com/p/drmemory/issues/detail?id=475
 ...
@@ -447,29 +461,52 @@ CRYPT32.dll!CryptMsgOpenToDecode
 ...
 CRYPT32.dll!CryptQueryObject
 
+# Lots of leaks from our interactions with the system certificate store.  May be
+# worth reviewing our use of their API.
 LEAK
 name=http://code.google.com/p/drmemory/issues/detail?id=476 a
+KERNEL*.dll!LocalAlloc
 ...
-RPCRT4.dll!RpcBindingFromStringBindingW
-...
-NETAPI32.dll!DsRoleGetPrimaryDomainInformation
+CRYPT32.dll!CertGetCRLContextProperty
+
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=476 b
+KERNEL*.dll!LocalAlloc
 ...
-USERENV.dll!CreateEnvironmentBlock
+CRYPT32.dll!CertAddCRLContextToStore
+
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=476 c
+KERNEL*.dll!LocalAlloc
 ...
 CRYPT32.dll!CertOpenStore
-...
-CRYPT32.dll!CertCreateCertificateChainEngine
 
 LEAK
-name=http://code.google.com/p/drmemory/issues/detail?id=476 b
-KERNEL32.dll!LocalAlloc
+name=http://code.google.com/p/drmemory/issues/detail?id=476 d
+RSAENH.dll!*
 ...
-CRYPT32.dll!CryptDecodeObjectEx
+CRYPT32.dll!CertGetCertificateChain
+
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=476 e
+RPCRT4.dll!*
 ...
-CRYPT32.dll!CertGetCRLContextProperty
+CRYPT32.dll!CertGetCertificateChain
+
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=476 f
+KERNELBASE.dll!LocalAlloc
+SETUPAPI.dll!*
 ...
 CRYPT32.dll!CertGetCertificateChain
 
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=476 g
+RPCRT4.dll!*
+RPCRT4.dll!*
+...
+CRYPT32.dll!CertCompareIntegerBlob
+
 UNINITIALIZED READ
 name=http://code.google.com/p/drmemory/issues/detail?id=511 a
 RPCRT4.dll!*
@@ -614,11 +651,17 @@ name=http://crbug.com/TODO m
 ...
 CRYPT32.dll!I_CertSyncStore
 
-# This test intentionally leaks an object and checks that it's never deleted
-LEAK
-name=http://crbug.com/TODO n
-...
-*!BrowserThreadTest_NotReleasedIfTargetThreadNonExistent_Test::TestBody
+# This matches the same stack as DrMem i#751, but it's an uninit read instead of
+# a leak.  Must be some early thread initialization.  Doesn't look like
+# bit-level though.
+UNINITIALIZED READ
+name=http://crbug.com/TODO o
+RPCRT4.dll!*
+RPCRT4.dll!*
+RPCRT4.dll!*
+ntdll.dll!*
+ntdll.dll!*
+KERNEL*.dll!BaseThreadInitThunk
 
 LEAK
 name=http://crbug.com/109278 video device COM leaks
@@ -630,11 +673,6 @@ name=http://crbug.com/109278 audio device COM leaks
 ...
 *!GetInputDeviceNamesWin
 
-LEAK
-name=http://crbug.com/109281 TLS root isn't found by DrMemory
-...
-*!base::ThreadLocalStorage::Initialize
-
 # Looks like an unhandled syscall.
 UNINITIALIZED READ
 name=http://code.google.com/p/drmemory/issues/detail?id=744 a
@@ -743,9 +781,37 @@ UNINITIALIZED READ
 name=http://code.google.com/p/drmemory/issues/detail?id=493
 USP10.dll!ScriptPositionSingleGlyph
 
+# Various TLS leaks that we don't understand yet.  We should be finding a root
+# for these.
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=778 a
+KERNELBASE.dll!TlsSetValue
+RSAENH.dll!*
+RSAENH.dll!*
+
+# Originally filed as: http://crbug.com/109281
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=778 b
+...
+*!base::ThreadLocalStorage::Initialize
+
+# This is an NSS PRThread object installed in TLS.  Why isn't this detected as a
+# root?  See also http://crbug.com/32624
+LEAK
+name=http://code.google.com/p/drmemory/issues/detail?id=778 c
+*!PR_Calloc
+*!_PR_AttachThread
+*!_PRI_AttachThread
+
 ###############################################################
 # Benign issues in Chromium
 
+# This test intentionally leaks an object and checks that it's never deleted.
+LEAK
+name=BrowserThreadTest.NotReleasedIfTargetThreadNonExistant leak
+...
+*!BrowserThreadTest_NotReleasedIfTargetThreadNonExistent_Test::TestBody
+
 LEAK
 name=deliberate histogram leak
 ...
@@ -838,15 +904,22 @@ name=http://crbug.com/70062
 *!net::SSL*SocketNSS::DoHandshakeLoop
 
 LEAK
-name=http://crbug.com/74417
+name=http://crbug.com/74417 a
 *!operator new
 *!disk_cache::BackendImpl::CreateEntryImpl
 
 LEAK
-name=http://crbug.com/74425
+name=http://crbug.com/74417 b
 *!operator new
 *!disk_cache::BackendImpl::NewEntry
 
+# One more disk_cache::BackendImpl leak.  See also http://crbug.com/87500.
+LEAK
+name=http://crbug.com/74417 c
+*!operator new
+...
+*!disk_cache::EntryImpl::UserBuffer::UserBuffer
+
 LEAK
 name=http://crbug.com/75247
 ...
diff --git a/tools/valgrind/test_suppressions.py b/tools/valgrind/test_suppressions.py
index 1492e52..d9a6cb4 100644..100755
--- a/tools/valgrind/test_suppressions.py
+++ b/tools/valgrind/test_suppressions.py
@@ -98,10 +98,10 @@ def main(argv):
     elif all([re.search("%20Heapcheck", url)
               for url in all_reports[r]]):
       cur_supp += heapcheck_suppressions
-    elif all(["DrMemory%20full" in url for url in all_reports[r]]):
-      cur_supp += drmem_suppressions + drmem_full_suppressions
-    elif all(["DrMemory" in url for url in all_reports[r]]):
+    if all(["DrMemory" in url for url in all_reports[r]]):
       cur_supp += drmem_suppressions
+    if all(["DrMemory%20full" in url for url in all_reports[r]]):
+      cur_supp += drmem_full_suppressions
 
     match = False
     for s in cur_supp: