summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authoryurys@chromium.org <yurys@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-14 18:15:18 +0000
committeryurys@chromium.org <yurys@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-14 18:15:18 +0000
commit0627301419e4e6fe800c5318dd86d2028124e4f7 (patch)
tree9e0b4c73127867bd9260434e620a3535f70582d1 /tools
parent8c95530c954fe6b273f1c67b1201506bdc53281e (diff)
downloadchromium_src-0627301419e4e6fe800c5318dd86d2028124e4f7.zip
chromium_src-0627301419e4e6fe800c5318dd86d2028124e4f7.tar.gz
chromium_src-0627301419e4e6fe800c5318dd86d2028124e4f7.tar.bz2
Remove usages of HeapProfiler.finishHeapSnapshot from telemetry
BUG=306475 Review URL: https://codereview.chromium.org/27190003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228495 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py12
1 files changed, 5 insertions, 7 deletions
diff --git a/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py
index 70508b5..ad1cb04 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py
@@ -330,15 +330,13 @@ class InspectorBackend(object):
# This is a hack to make the nested function be able to modify the
# variables.
snapshot_uid = [0]
- snapshot = [[]]
+ snapshot = []
def OnNotification(res):
if res['method'] == 'HeapProfiler.addProfileHeader':
snapshot_uid[0] = res['params']['header']['uid']
elif res['method'] == 'HeapProfiler.addHeapSnapshotChunk':
- snapshot[0].append(res['params']['chunk'])
- elif res['method'] == 'HeapProfiler.finishHeapSnapshot':
- snapshot[0] = ''.join(snapshot[0])
+ snapshot.append(res['params']['chunk'])
def OnClose():
pass
@@ -348,10 +346,10 @@ class InspectorBackend(object):
self.SyncRequest({'method': 'Page.getResourceTree'}, timeout)
self.SyncRequest({'method': 'Debugger.enable'}, timeout)
self.SyncRequest({'method': 'HeapProfiler.clearProfiles'}, timeout)
- self.SyncRequest({'method': 'HeapProfiler.takeHeapSnapshot',
- 'params': {'detailed': True}}, timeout)
+ self.SyncRequest({'method': 'HeapProfiler.takeHeapSnapshot'}, timeout)
self.SyncRequest({'method': 'HeapProfiler.getHeapSnapshot',
'params': {'uid': snapshot_uid[0]}}, timeout)
+ snapshot = ''.join(snapshot)
self.UnregisterDomain('HeapProfiler')
- return model.Model(snapshot[0])
+ return model.Model(snapshot)