diff options
| author | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-21 23:34:57 +0000 |
|---|---|---|
| committer | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-21 23:34:57 +0000 |
| commit | 8533b4b0db6cdbedb2feb40d2ea3a54fb03db963 (patch) | |
| tree | 68ed0ecd53549742958c63d9a83a367ddc3e964b /tools | |
| parent | 4a78da0ade4d028c60681c1403fc4a2c2b85a73f (diff) | |
| download | chromium_src-8533b4b0db6cdbedb2feb40d2ea3a54fb03db963.zip chromium_src-8533b4b0db6cdbedb2feb40d2ea3a54fb03db963.tar.gz chromium_src-8533b4b0db6cdbedb2feb40d2ea3a54fb03db963.tar.bz2 | |
gtk: Two fixes for the tab leak:
* The tab strip handles the lifetime of the tab widget, so don't try to increase the ref count in order to destroy the widget later.
* Use DeleteSoon when deleting the dragged tab in order to give gtk a chance to clean up its ref counts added during the drag operation.
BUG=12863
TEST=Extensive tab dragging. No crashes and the Linux UI valgrind bot should stay green.
Review URL: http://codereview.chromium.org/159166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21230 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index d5e53a9..fc8c02b 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -622,18 +622,6 @@ fun:_ZNK11webkit_glue12ImageDecoder6DecodeEPKhj } { - # very common in ui tests - bug_12863 - Memcheck:Leak - fun:malloc - fun:g_malloc - ... - fun:gtk_event_box_new - fun:_ZN6TabGtkC1EPNS_11TabDelegateE - fun:_ZN11TabStripGtk13TabInsertedAtEP11TabContentsib - fun:_ZN13TabStripModel19InsertTabContentsAtEiP11TabContentsbb -} -{ bug_15762 Memcheck:Cond fun:_ZN7testing8internal11CmpHelperEQIjjEENS_15AssertionResultEPKcS4_RKT_RKT0_ |