summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorjoth@chromium.org <joth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-31 15:29:27 +0000
committerjoth@chromium.org <joth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-31 15:29:27 +0000
commita0645703e4069c2def1dff4cca774ec47763d052 (patch)
tree190b36498c5557d8e2dc17b399f1c21e229ac083 /tools
parenta21643a4c0c76665b8820caf3103e0d8309ac094 (diff)
downloadchromium_src-a0645703e4069c2def1dff4cca774ec47763d052.zip
chromium_src-a0645703e4069c2def1dff4cca774ec47763d052.tar.gz
chromium_src-a0645703e4069c2def1dff4cca774ec47763d052.tar.bz2
Revert 107939 - Pile of nits for tracked object enablement
[Re-land of Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107921 with supressions for induced (and planned) leaks) PLUS Removed one line of defensive coding where I set(NULL) the TLS slote at thread teardown. We're seeing strange failures on the base unittests, and they may be related to this. ] Be extra carful about handling races in access to status_. This will avoid generating a delta between a null time and a real time, when status is changing in/around the run of a task. This won't help with the benign race for checking status_, but it may help with unit test tsan complaints. Leak data aggressively, rather than cleaning up, to prevent any chance of a data access race between tracked object testing (which need a near-virgin global state, and hence must start by cleaning it up), and other tests, which may have lingering threaded actions, that still access some previously created task tracking data. Provide more options for flags to enable/disable tracking. These options might become useful if we changed the default to not do tracking. Allow for HTML generation even if the tracking has changed to being disabled. This is especially useful for looking at the tracked instances that were monitored after turning tracking on by default, but before the command line deactiated tracking. tbr=rtenneti bug=102327 Review URL: http://codereview.chromium.org/8425010 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8430003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107960 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/heapcheck/suppressions.txt18
1 files changed, 0 insertions, 18 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt
index 4631429..d40be91 100644
--- a/tools/heapcheck/suppressions.txt
+++ b/tools/heapcheck/suppressions.txt
@@ -194,29 +194,11 @@
fun:base::LazyInstance::Pointer
}
{
- Intentional leak in object tracking statics to avoid shutdown race
- Heapcheck:Leak
- ...
- fun:tracked_objects::ThreadData::Initialize*
-}
-{
Give breathing room for tracked object tests.. may do better later.
Heapcheck:Leak
...
fun:tracked_objects::TrackedObjectsTest*
}
-{
- Intentional leak in object tracking of thread context to avoid shutdown race
- Heapcheck:Leak
- ...
- fun:tracked_objects::ThreadData::Get
-}
-{
- Intentional leak of task birth and death data to avoid shutdown race
- Heapcheck:Leak
- ...
- fun:tracked_objects::ThreadData::TallyA*
-}
#-----------------------------------------------------------------------
# 3. Suppressions for real chromium bugs that are not yet fixed.
# These should all be in chromium's bug tracking system (but a few aren't yet).