diff options
| author | pastarmovj@chromium.org <pastarmovj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-21 12:44:32 +0000 |
|---|---|---|
| committer | pastarmovj@chromium.org <pastarmovj@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-21 12:44:32 +0000 |
| commit | 93cc27bf467e4914ebd98d27e0ea551d2debb666 (patch) | |
| tree | 45f704fc7213c7bc182dc062ef08f5ffcf376681 /tools | |
| parent | 1d384e11d21e58c4c6cd0e0b69d9008fcc0a4ed4 (diff) | |
| download | chromium_src-93cc27bf467e4914ebd98d27e0ea551d2debb666.zip chromium_src-93cc27bf467e4914ebd98d27e0ea551d2debb666.tar.gz chromium_src-93cc27bf467e4914ebd98d27e0ea551d2debb666.tar.bz2 | |
Fix UserManager to not leak the mock managers created for unit tests.
All tests share the singletons and if mocks are leaked state will be leaked
and possibly corrupted between the tests. This CL tries to force every test
that needs a particular UserManager state to use its own mock object and set
it in the wanted state.
BUG=116996
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/9705016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127946 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 41 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 18 |
2 files changed, 0 insertions, 59 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index c0284e5..d38c5b8 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1766,47 +1766,6 @@ fun:chromeos::DesktopNotificationsTest::SetUp } { - bug_116996_a - Heapcheck:Leak - fun:chromeos::UserManagerImpl::CreateUser - ... - fun:chromeos::UserManagerImpl::UserLoggedIn - fun:chromeos::*_Test::TestBody -} -{ - bug_116996_b - Heapcheck:Leak - ... - fun:SkBitmap::HeapAllocator::allocPixelRef - fun:SkBitmap::allocPixels - fun:SkBitmap::allocPixels - fun:gfx::::DecodeInfoCallback - fun:wk_png_push_have_info - fun:wk_png_push_read_chunk - fun:wk_png_process_some_data - fun:wk_png_process_data - fun:gfx::PNGCodec::Decode - fun:ui::ResourceBundle::LoadBitmap - fun:ui::ResourceBundle::GetImageNamed - fun:ui::ResourceBundle::GetBitmapNamed -} -{ - bug_116996_c - Heapcheck:Leak - fun:std::*string::_Rep::_S_create - fun:std::*string::copy - fun:std::basic_string::basic_string - fun:chromeos::*_Test::TestBody -} -{ - bug_116996_d - Heapcheck:Leak - fun:chromeos::UserManagerImpl::CreateUser - fun:chromeos::UserManagerImpl::EnsureUsersLoaded - fun:chromeos::UserManagerImpl::GetUsers - fun:chromeos::UserManagerTest_*_Test::TestBody -} -{ bug_117098_a Heapcheck:Leak fun:base::internal::WeakReferenceOwner::GetRef diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 656ae21..6141574 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -5696,24 +5696,6 @@ fun:_ZN8chromeos24DesktopNotificationsTest5SetUpEv } { - bug_116996_a - Memcheck:Leak - fun:_Znw* - fun:_ZNK8chromeos15UserManagerImpl10CreateUserERKSs - ... - fun:_ZN8chromeos15UserManagerImpl12UserLoggedInERKSs - fun:_ZN8chromeos*_Test8TestBodyEv -} -{ - bug_116996_b - Memcheck:Leak - fun:_Znw* - fun:_ZNK8chromeos15UserManagerImpl10CreateUserERKSs - fun:_ZN8chromeos15UserManagerImpl17EnsureUsersLoadedEv - fun:_ZNK8chromeos15UserManagerImpl8GetUsersEv - fun:_ZN8chromeos*_Test8TestBodyEv -} -{ bug_117098 Memcheck:Leak fun:_Znw* |