diff options
| author | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-21 19:46:00 +0000 |
|---|---|---|
| committer | timurrrr@chromium.org <timurrrr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-21 19:46:00 +0000 |
| commit | e4a638f76ada2aaacd46f0adb2037e28dffc3648 (patch) | |
| tree | b7f298e554610b3086d225791b29a7309d712ca6 /tools | |
| parent | 995620de09bfbac3354b8bc2073bd4c68e52d8f7 (diff) | |
| download | chromium_src-e4a638f76ada2aaacd46f0adb2037e28dffc3648.zip chromium_src-e4a638f76ada2aaacd46f0adb2037e28dffc3648.tar.gz chromium_src-e4a638f76ada2aaacd46f0adb2037e28dffc3648.tar.bz2 | |
Make the placement-new buffer in LazyInstance<Type> aligned.
Before, the LazyInstance::buf_ was 4-byte aligned on x64, which is wrong.
WHY?! I thought buf_ is the first member of LazyInstance?!
NO! LazyInstance inherits LazyInstanceHelper, sizeof(LIH) = 4.
Then, buf_ is given to placement new.
As a result, the LazyInstance<Type> instances are all 4-byte aligned on x64.
This may break some stuff like SSE-based optimizations assuming the instance is
8-bytes aligned (fair assumption).
Also, if Type contains a bunch of std::vector/hash_map's, their pointers occupy
two half-words and Valgrind doesn't traverse to their data, reporting a false leak.
BUG=64930
Review URL: http://codereview.chromium.org/8366041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106763 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index dce9776..cd791d5 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -605,16 +605,6 @@ fun:CERT_ChangeCertTrust } { - bug_64930 [vector-under-hashtable false positive leaks on x64] - Memcheck:Leak - ... - fun:_ZNSt6vector* - fun:_ZNSt6vector* - fun:_ZN9__gnu_cxx9hashtable* - fun:_ZN9__gnu_cxx9hashtable* - fun:_ZN9__gnu_cxx8hash_map* -} -{ leaks in bash Memcheck:Leak ... |