summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorhashimoto@chromium.org <hashimoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-07 06:13:54 +0000
committerhashimoto@chromium.org <hashimoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-07 06:13:54 +0000
commit34d3d441d8a02cf9ec4c3586ee762e022ee6cbf5 (patch)
tree8022f145127b3147465885703300196cfd051821 /tools
parent8246ed39313592547db84a47ca5b4ae6d65221d9 (diff)
downloadchromium_src-34d3d441d8a02cf9ec4c3586ee762e022ee6cbf5.zip
chromium_src-34d3d441d8a02cf9ec4c3586ee762e022ee6cbf5.tar.gz
chromium_src-34d3d441d8a02cf9ec4c3586ee762e022ee6cbf5.tar.bz2
Revert 233460 "Prefer opening PDF downloads in the browser."
Caused "PluginPrefsTest.UnifiedPepperFlashState" failure on "Linux Clang (dbg)" BUG=316017 > Prefer opening PDF downloads in the browser. > > PDFs in particular are safer to open in the browser. This patch changes > the handling of downloads to open such files in the browser by default > instead of the system handler for the file type. A "Open with system > handler" menu item will be available so that users can still use the > system application if needed. > > The determination that a file is safer to handle in the browser is done > as follows: > > a) DownloadTargetDeterminer determines whether the MIME type > corresponding to the target filename of the download is one which is > handled by the renderer or one that is handled by a sandboxed pepper > plugin. If so, then the file is considered safely handled by the > browser. > > b) ChromeDownloadManagerDelegate determines whether opening in the > browser is preferred for the file type assuming the browser is able > to handle it safely. Currently this is true for .pdf files. > > Opening behavior for a download will default to opening in the browser > if both results from a) and b) are true. > > BUG=148492 > > TEST=(1) Make sure Chrome PDF Viewer is enabled in chrome://plugins. > (2) Download a .pdf file. > (3) Download shelf context menu should show "Open" and "Open with > system handler" options. > (4) "Open" as well as clicking on the shelf icon and clicking on > the download in chrome://downloads should all result in opening > the file within the browser. > (5) "Open with system handler" should open the .pdf with the > application that's set up as the default handler for .pdf files > on the users' machine. > > Review URL: https://codereview.chromium.org/55063002 TBR=asanka@chromium.org Review URL: https://codereview.chromium.org/61623006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233497 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/metrics/histograms/histograms.xml14
1 files changed, 0 insertions, 14 deletions
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index e4ad3d9..e436151 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3060,14 +3060,6 @@ other types of suffix sets.
</summary>
</histogram>
-<histogram name="Download.OpenMethod" enum="DownloadOpenMethod">
- <summary>
- Invocation count for methods of opening a download. For some file types,
- Chrome defaults to opening the file in the browser instead of invoking the
- system handler. The user has the option of overriding this behavior.
- </summary>
-</histogram>
-
<histogram name="Download.OpensOutstanding">
<summary>The number of unopened downloads, when one is opened.</summary>
</histogram>
@@ -21417,12 +21409,6 @@ other types of suffix sets.
<int value="8" label="POTENTIALLY_UNWANTED"/>
</enum>
-<enum name="DownloadOpenMethod" type="int">
- <int value="0" label="Opened with plaform handler by default"/>
- <int value="1" label="Opened in browser by default"/>
- <int value="2" label="Opened with plaform handler by user choice"/>
-</enum>
-
<enum name="DownloadSavePackageEvent" type="int">
<int value="0" label="Started"/>
<int value="1" label="Cancelled"/>