diff options
| author | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-05 23:03:34 +0000 |
|---|---|---|
| committer | glen@chromium.org <glen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-05 23:03:34 +0000 |
| commit | 105513ed46986be8c3089497bc6b960f4648044f (patch) | |
| tree | 61bf803b0b97ec3ed0c9da962acfcd20ebb9e894 /tools | |
| parent | 68d3c9eabf88ed410127c6ef3ffaf6f007c74a19 (diff) | |
| download | chromium_src-105513ed46986be8c3089497bc6b960f4648044f.zip chromium_src-105513ed46986be8c3089497bc6b960f4648044f.tar.gz chromium_src-105513ed46986be8c3089497bc6b960f4648044f.tar.bz2 | |
Retry. I believe the code (with your width() * bbp fix) is correct.
The UMR errors occur when the source image contain alpha. I believe the issue comes from webkit glue image decoder, and the reason this only started triggering valgrind errors is that the old ones were masked by the change detailed in bug 12640
Also adds valgrind suppression for the new code.
BUG=12891,12640
TEST=none
Review URL: http://codereview.chromium.org/118297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17792 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/suppressions_mac.txt | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/tools/valgrind/suppressions_mac.txt b/tools/valgrind/suppressions_mac.txt index 1db729f..66bc8c2 100644 --- a/tools/valgrind/suppressions_mac.txt +++ b/tools/valgrind/suppressions_mac.txt @@ -220,3 +220,13 @@ fun:write$UNIX2003 fun:_ZN24ExtensionsServiceBackend19OnExtensionUnpackedERK8FilePathS2_SsbRK15DictionaryValueRKSt6vectorI6Tuple2I8SkBitmapS0_ESaIS9_EE } +{ + bug_12640d + Memcheck:Cond + fun:_ZN10PNGEncoder18EncodeBGRASkBitmapERK8SkBitmapbPSt6vectorIhSaIhEE + fun:_ZN24ExtensionsServiceBackend19OnExtensionUnpackedERK8FilePathS2_SsbRK15DictionaryValueRKSt6vectorI6Tuple2I8SkBitmapS0_ESaIS9_EE + fun:_ZN24ExtensionsServiceBackend14UnpackerClient26OnUnpackExtensionSucceededERK15DictionaryValueRKSt6vectorI6Tuple2I8SkBitmap8FilePathESaIS8_EE + ... + fun:_ZN11MessageLoop13RunAllPendingEv +} + |