diff options
| author | feldstein@chromium.org <feldstein@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 21:47:11 +0000 |
|---|---|---|
| committer | feldstein@chromium.org <feldstein@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 21:47:11 +0000 |
| commit | 6a7a303f06944a1781edb94f4032865b4406ca1c (patch) | |
| tree | 4f474a2760955f7ca3d3dc94bc1e87157f87f93b /tools | |
| parent | 62c4e64828e906b7597eae4418b6cf3c93502d49 (diff) | |
| download | chromium_src-6a7a303f06944a1781edb94f4032865b4406ca1c.zip chromium_src-6a7a303f06944a1781edb94f4032865b4406ca1c.tar.gz chromium_src-6a7a303f06944a1781edb94f4032865b4406ca1c.tar.bz2 | |
Stop using measurements to determine list item
Currently the list uses the list item height and the offsetTop to determine
which item was clicked on. This doesn't work if the list has no padding, it
thinks you clicked on the one before it. Now i attach the data item to the
element, and use that to look up the index in the model.
I was also thinking about creating a standard click handler that dispatches an
itemClicked event with that item attached, so subclasses don't all have to
implement the same code. Do you think this is a good idea, or should we leave
the base class simpler.
BUG=none
TEST=click an item in a list with no padding.
Review URL: http://codereview.chromium.org/2813043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51568 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions