summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authordgrogan@chromium.org <dgrogan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-10 03:02:41 +0000
committerdgrogan@chromium.org <dgrogan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-10 03:02:41 +0000
commit833225d94a0e76dfe49de08b9b088bed1bfd256d (patch)
tree85e50566c574a3c9ed9c468811eefc3e7581f22d /tools
parent2f2d6c30d9a28022847febc13d92d3073c294674 (diff)
downloadchromium_src-833225d94a0e76dfe49de08b9b088bed1bfd256d.zip
chromium_src-833225d94a0e76dfe49de08b9b088bed1bfd256d.tar.gz
chromium_src-833225d94a0e76dfe49de08b9b088bed1bfd256d.tar.bz2
Check for and histogram one class of unsafe thread accesses in LevelDB.
This is where multiple threads may be using one FILE* handle. This patch doesn't address two threads reading/writing the same file through different handles. BUG=230154 Review URL: https://chromiumcodereview.appspot.com/14772024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199348 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/metrics/histograms/histograms.xml8
1 files changed, 8 insertions, 0 deletions
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f53e7c5..bea1250 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -924,6 +924,14 @@ other types of suffix sets.
</summary>
</histogram>
+<histogram name="LevelDBEnv.All.SafeThreadAccess" units="accesses">
+ <summary>
+ Linux and CrOS use unlocked_stdio(3). If it is used unsafely, record it
+ here. If there is no record of unsafety after chrome 29 has been in the
+ stable channel for a few weeks then revert this change.
+ </summary>
+</histogram>
+
<histogram name="LevelDBEnv.IDB.IOError" enum="LevelDBIOErrorMethods">
<summary>
Methods where leveldb's Chromium environment has IO errors when being used