diff options
| author | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-11 00:00:54 +0000 |
|---|---|---|
| committer | wtc@chromium.org <wtc@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-11 00:00:54 +0000 |
| commit | 8e85e9a3dde65b8518b93ca44c87e1681abcd42a (patch) | |
| tree | 0566d1c63596c466e25d4cb2d8a68ffbb01b4cb3 /tools | |
| parent | ce7f62e3d9d64f40db04dc475c7b67ef7c8a4223 (diff) | |
| download | chromium_src-8e85e9a3dde65b8518b93ca44c87e1681abcd42a.zip chromium_src-8e85e9a3dde65b8518b93ca44c87e1681abcd42a.tar.gz chromium_src-8e85e9a3dde65b8518b93ca44c87e1681abcd42a.tar.bz2 | |
Build just chrome to shorten the Coverity build and analysis
time.
Remove a stale TODO comment.
R=bevc,jimhebert
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3175001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55637 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/coverity/coverity.py | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/tools/coverity/coverity.py b/tools/coverity/coverity.py index 896ebc6..d19b622 100644 --- a/tools/coverity/coverity.py +++ b/tools/coverity/coverity.py @@ -88,8 +88,6 @@ def _RunCommand(cmd, dry_run, shell=False, echo_cmd=True): """Runs the command if dry_run is false, otherwise just prints the command.""" if echo_cmd: print cmd - # TODO(wtc): Check the return value of subprocess.call, which is the return - # value of the command. if not dry_run: return subprocess.call(cmd, shell=shell) else: @@ -171,19 +169,20 @@ def main(options, args): use_shell_during_make = True os.chdir('src') _RunCommand('pwd', options.dry_run, shell=True) - cmd = '%s/cov-build --dir %s make BUILDTYPE=%s' % ( + cmd = '%s/cov-build --dir %s make BUILDTYPE=%s chrome' % ( options.coverity_bin_dir, options.coverity_intermediate_dir, options.target) elif sys.platform == 'win32': - cmd = '%s\\cov-build.exe --dir %s devenv.com %s\\%s /build %s' % ( + cmd = ('%s\\cov-build.exe --dir %s devenv.com %s\\%s /build %s ' + '/project chrome.vcproj') % ( options.coverity_bin_dir, options.coverity_intermediate_dir, options.source_dir, options.solution_file, options.target) elif sys.platform == 'darwin': use_shell_during_make = True - os.chdir('src/build') + os.chdir('src/chrome') _RunCommand('pwd', options.dry_run, shell=True) - cmd = ('%s/cov-build --dir %s xcodebuild -project all.xcodeproj ' - '-configuration %s -target All') % ( + cmd = ('%s/cov-build --dir %s xcodebuild -project chrome.xcodeproj ' + '-configuration %s -target chrome') % ( options.coverity_bin_dir, options.coverity_intermediate_dir, options.target) |