diff options
| author | tonyg@chromium.org <tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-06 16:39:28 +0000 |
|---|---|---|
| committer | tonyg@chromium.org <tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-06 16:39:28 +0000 |
| commit | d1aacc970c3cae86fa65645f0edd3ba92b588659 (patch) | |
| tree | 32687925439e40cd9c39a21ede8951b0ae32ab87 /tools | |
| parent | 847c0fa90f4b8c1ab948d3d230f2fcc428afe2a9 (diff) | |
| download | chromium_src-d1aacc970c3cae86fa65645f0edd3ba92b588659.zip chromium_src-d1aacc970c3cae86fa65645f0edd3ba92b588659.tar.gz chromium_src-d1aacc970c3cae86fa65645f0edd3ba92b588659.tar.bz2 | |
[chrome-remote-control] Avoid bad results upon failure.
Don't print perfbot results if there were page failures. Currently the test is
failing on some pages about once every 100 runs. When that happens, the results
for a subset of pages are reported. After this patch, we won't report any
results when there is a failure.
See the blue spikes here:
http://build.chromium.org/f/chromium/perf/chromium-rel-win7-gpu-intel/scrolling_benchmark/report.html?history=400&rev=-1&graph=mean_frame_time
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/11293109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166218 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py b/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py index 2cc6018..28fff34 100644 --- a/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py +++ b/tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py @@ -70,6 +70,8 @@ results! You must return the same dict keys every time.""" self.results_summary[(name, units, data_type)].append(value) def PrintSummary(self, trace_tag): + if self.page_failures: + return for measurement_units_type, values in sorted( self.results_summary.iteritems()): measurement, units, data_type = measurement_units_type |