diff options
| author | stuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-07 15:36:01 +0000 |
|---|---|---|
| committer | stuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-07 15:36:01 +0000 |
| commit | 2f4294538dea93c4b48b20b9b564d09bb7591301 (patch) | |
| tree | a370e5b00acea2b72f22517e5a67131e2de02a4b /tools | |
| parent | 94b26710c1ffef6bcff61e9ff22cb58f434f7e37 (diff) | |
| download | chromium_src-2f4294538dea93c4b48b20b9b564d09bb7591301.zip chromium_src-2f4294538dea93c4b48b20b9b564d09bb7591301.tar.gz chromium_src-2f4294538dea93c4b48b20b9b564d09bb7591301.tar.bz2 | |
Presumbit check for 'Suppression:' in valgrind suppressions
BUG=None
TEST=Try to accidentally break the valgrind suppressions by pasting too much into the file; fail.
Review URL: http://codereview.chromium.org/2847044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51717 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/valgrind/memcheck/PRESUBMIT.py | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/tools/valgrind/memcheck/PRESUBMIT.py b/tools/valgrind/memcheck/PRESUBMIT.py index 5616436..dd9861c 100755 --- a/tools/valgrind/memcheck/PRESUBMIT.py +++ b/tools/valgrind/memcheck/PRESUBMIT.py @@ -7,5 +7,22 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for more details on the presubmit API built into gcl. """ +def CheckChange(input_api, output_api): + """Checks that the user didn't paste 'Suppression:' into the file""" + keyword = 'Suppression:' + for f, line_num, line in input_api.RightHandSideLines(lambda x: + x.LocalPath().endswith('.txt')): + if keyword in line: + text = '"%s" must not be included; %s line %s' % ( + keyword, f.LocalPath(), line_num) + return [output_api.PresubmitError(text)] + return [] + +def CheckChangeOnUpload(input_api, output_api): + return CheckChange(input_api, output_api) + +def CheckChangeOnCommit(input_api, output_api): + return CheckChange(input_api, output_api) + def GetPreferredTrySlaves(): return ['linux_valgrind', 'mac_valgrind'] |