diff options
| author | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-05 00:56:56 +0000 |
|---|---|---|
| committer | shess@chromium.org <shess@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-05 00:56:56 +0000 |
| commit | 3266992f388387cb5f731cb36fa75d5ac65a7901 (patch) | |
| tree | b3df8fcd06bae3aa200285aac00b289d111d5da0 /tools | |
| parent | 8c96af8431a78412ce6cdec1f5d0cf2c0a2f1e9a (diff) | |
| download | chromium_src-3266992f388387cb5f731cb36fa75d5ac65a7901.zip chromium_src-3266992f388387cb5f731cb36fa75d5ac65a7901.tar.gz chromium_src-3266992f388387cb5f731cb36fa75d5ac65a7901.tar.bz2 | |
[Mac] Add testing code to expose an NSColor memory leak.
AutocompleteTextFieldCell calls -keyboardFocusIndicatorColor when
drawing the focus ring, which valgrind considers a leak. While we
were testing drawing when not focussed, unit tests could not test
drawing when focussed without the window being made key, which is bad
for many reasons.
This change adds some code to allow faking the key window, then adds
tests for drawing when focussed which exposes the memory leak, then
adds a suppression for that memory leak.
http://crbug.com/21137
TEST=valgrind AutocompleteTextFieldCellTest.Display
Review URL: http://codereview.chromium.org/192031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25567 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions_mac.txt | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/tools/valgrind/memcheck/suppressions_mac.txt b/tools/valgrind/memcheck/suppressions_mac.txt index 3a513c0..daa2145 100644 --- a/tools/valgrind/memcheck/suppressions_mac.txt +++ b/tools/valgrind/memcheck/suppressions_mac.txt @@ -673,4 +673,13 @@ socketcall.sendmsg(msg.msg_iov[i]) fun:sendmsg$UNIX2003 fun:_ZN3IPC7Channel11ChannelImpl4SendEPNS_7MessageE +} +{ + bug_21137 + Memcheck:Leak + fun:malloc + ... + fun:+[NSColor keyboardFocusIndicatorColor] + ... + fun:-[AutocompleteTextFieldCell drawWithFrame:inView:] } |