diff options
| author | tsepez@chromium.org <tsepez@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-01 16:26:00 +0000 |
|---|---|---|
| committer | tsepez@chromium.org <tsepez@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-01 16:26:00 +0000 |
| commit | 380d73d0685b9f2182c8b324bb3fdbdbb5062c47 (patch) | |
| tree | 6320f2a3793042a3f606f54ab2280b02069a12cf /tools | |
| parent | b8b12fde23a9b1cafbd2b094a5e180e4086dbded (diff) | |
| download | chromium_src-380d73d0685b9f2182c8b324bb3fdbdbb5062c47.zip chromium_src-380d73d0685b9f2182c8b324bb3fdbdbb5062c47.tar.gz chromium_src-380d73d0685b9f2182c8b324bb3fdbdbb5062c47.tar.bz2 | |
Fix obvious leak in chrome_web_ui_data_source_unittest.cc, and revert associated suppresions.
BUG=88094
TEST=heapchecks clean about ChromeWebUIDataSource
Review URL: http://codereview.chromium.org/7278008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91303 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/heapcheck/suppressions.txt | 7 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 32 |
2 files changed, 0 insertions, 39 deletions
diff --git a/tools/heapcheck/suppressions.txt b/tools/heapcheck/suppressions.txt index 257dce5..be2f8bd 100644 --- a/tools/heapcheck/suppressions.txt +++ b/tools/heapcheck/suppressions.txt @@ -1629,11 +1629,4 @@ fun:TabContentsWrapperTestHarness::SetUp fun:GeolocationPermissionContextTests::SetUp } -{ - bug_88094 - Heapcheck:Leak - ... - fun:ChromeWebUIDataSourceTest* -} - diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 9d55212..bc9df60 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -4808,38 +4808,6 @@ fun:_ZN33GeolocationInfoBarQueueController20CreateInfoBarRequestEiiiRK4GURLS2_ fun:_ZN34ChromeGeolocationPermissionContext28RequestGeolocationPermissionEiiiRK4GURL } -{ - bug_88094_a - Memcheck:Leak - fun:_Znw* - fun:_ZN25ChromeWebUIDataSourceTest5SetUpEv -} -{ - bug_88094_b - Memcheck:Leak - fun:_Znw* - fun:_ZN9__gnu_cxx13new_allocatorISt13_Rb_tree_nodeISt4pairIKSsP5ValueEEE8allocateEmPKv - fun:_ZNSt8_Rb_treeISsSt4pairIKSsP5ValueESt10_Select1stIS4_ESt4lessISsESaIS4_EE11_M_get_nodeEv - ... - fun:_ZN20ChromeURLDataManager10DataSource23SetFontAndTextDirectionEP15DictionaryValue - fun:_ZN21ChromeWebUIDataSource26SendLocalizedStringsAsJSONEi - fun:_ZN21ChromeWebUIDataSource16StartDataRequestERKSsbi -} -{ - bug_88094_c - Memcheck:Leak - fun:_Znw* - fun:_ZN9__gnu_cxx13new_allocatorISt13_Rb_tree_nodeISt4pairIKSsP5ValueEEE8allocateEjPKv - fun:_ZNSt8_Rb_treeISsSt4pairIKSsP5ValueESt10_Select1stIS4_ESt4lessISsESaIS4_EE11_M_get_nodeEv - ... - fun:_ZN15DictionaryValue23SetWithoutPathExpansionERKSsP5Value - fun:_ZN15DictionaryValue3SetERKSsP5Value - fun:_ZN15DictionaryValue9SetStringERKSsRKSbItN4base20string16_char_traitsESaItEE - fun:_ZN20ChromeURLDataManager10DataSource23SetFontAndTextDirectionEP15DictionaryValue - fun:_ZN21ChromeWebUIDataSource26SendLocalizedStringsAsJSONEi - fun:_ZN21ChromeWebUIDataSource16StartDataRequestERKSsbi - fun:_ZN25MockChromeWebUIDataSource16StartDataRequestERKSsbi -} #----------------------------------------------------------------------- # These only occur on our Google workstations |