summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authordeanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-12 11:15:14 +0000
committerdeanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-12 11:15:14 +0000
commit4d79d76ed8e6a450fe5fdb5d7e2c539dbe5c6462 (patch)
treedf05674ae732d585d50ecada394e9e9c2bf0d0a3 /tools
parent739c52198933941ad2602533d7dc271a2854b600 (diff)
downloadchromium_src-4d79d76ed8e6a450fe5fdb5d7e2c539dbe5c6462.zip
chromium_src-4d79d76ed8e6a450fe5fdb5d7e2c539dbe5c6462.tar.gz
chromium_src-4d79d76ed8e6a450fe5fdb5d7e2c539dbe5c6462.tar.bz2
Better keyboard and mouse handling in Omnibox:
- Grab enter key events before they get to GtkTextView. We need to do this, otherwise enter when text is selected will replace the text, and we won't get a chance to catch that happening. This might have problems with IME, but it should be straightforward to fix anything IME related. - Don't deselect when we lose focus. This sometimes looks a bit strange, but it's the GTK thing to do. This also unbreaks copy and paste via the context menu, since popping up the context menu makes the GtkTextView lose focus. - Rewrite the inefficent newline eater. This should now only be needed for newlines that didn't come from the keyboard (like when you paste text). Use the builtin iter support for finding line boundaries, hopefully more efficient than checking the characters one by one. Still might have some bad behavior when pasting a ton of newline characters, but that can be improved later. This fixes inline autocomplete, you can now hit the enter key on an inline autocompleted suggestion, and you will get the intented navigation, instead of the navigation with the selected completion removed. This also adds support for alt-enter in Omnibox to navigate in a new tab. BUG=8236 Review URL: http://codereview.chromium.org/43072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11527 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions