diff options
author | feldstein@chromium.org <feldstein@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-07 01:31:08 +0000 |
---|---|---|
committer | feldstein@chromium.org <feldstein@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-07 01:31:08 +0000 |
commit | 60a50255ede2001cef2c52bee8377ede6fcd1473 (patch) | |
tree | f0254591e595b8742ac39199162ca3b513fa1f15 /tools | |
parent | ba89742ced6463b6d555b8caf3806ad45d48e39b (diff) | |
download | chromium_src-60a50255ede2001cef2c52bee8377ede6fcd1473.zip chromium_src-60a50255ede2001cef2c52bee8377ede6fcd1473.tar.gz chromium_src-60a50255ede2001cef2c52bee8377ede6fcd1473.tar.bz2 |
Fix stuck hover states on tab close buttons
Use the |bounds| property instead of the |frame| property when updating tracking rectangles and deciding whether the button has the mouse over it. We used to do this from the parent views context, but moved the code into the button itself and this broke.
Check the image state when the mouseDown event loop finishes. We can get into a weird state when the tabs resize and the close button is placed under the cursor. We update the image to highlight it, but if we click/hold the mouse button without moving the mouse, there are no mouseMove events and thus no mouseEntered, and thus no mouseExited (just assuming that's what is happening).
BUG=31279
TEST=Open a bunch of tabs, Click/hold on the last close button, then let go. Wit
hout moving the mouse at all, click/hold on the next button that moves under the
mouse. Drag mouse away from tab strip area and let go. It should unhighlight it
self.
Review URL: http://codereview.chromium.org/524016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35678 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions