diff options
| author | benwells@chromium.org <benwells@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-26 02:30:40 +0000 |
|---|---|---|
| committer | benwells@chromium.org <benwells@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-26 02:30:40 +0000 |
| commit | 6565395c162774ed5321a32ed9ef62455e021e8e (patch) | |
| tree | 003a2ffe23268348072220ff5096b450625dbabe /tools | |
| parent | 40646b01c67e88588d8c30881c2cf1145ad073e0 (diff) | |
| download | chromium_src-6565395c162774ed5321a32ed9ef62455e021e8e.zip chromium_src-6565395c162774ed5321a32ed9ef62455e021e8e.tar.gz chromium_src-6565395c162774ed5321a32ed9ef62455e021e8e.tar.bz2 | |
Fixed memory problem in ProtocolHandlerRegistry unit tests.
This memory problem only occurred in tests. It happens because the
shell worker, which does stuff on the file thread and is held onto
by message loops, was outliving the delegate which it used.
Fix is to not pass in a delegate but the only piece of information
it needs (whether to fake failure or not).
BUG=90248
TEST=Automated tests and valgrind bots
Review URL: http://codereview.chromium.org/7461060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94023 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/memcheck/suppressions.txt | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt index 84d205b..72c100e 100644 --- a/tools/valgrind/memcheck/suppressions.txt +++ b/tools/valgrind/memcheck/suppressions.txt @@ -4962,13 +4962,6 @@ fun:_Z16DispatchToMethodIN2pp5proxy26PPP_Instance_Private_ProxyEMS2_FviNS1_24SerializedVarReturnValueEEiNS1_13SerializedVarEEvPT_T0_RK6Tuple1IT1_EPSA_IT2_E } { - bug_90248 - Memcheck:Addr1 - fun:_ZN12FakeDelegate16force_os_failureEv - fun:_ZN24FakeProtocolClientWorker14CheckIsDefaultEv - fun:_ZN16ShellIntegration22DefaultWebClientWorker21ExecuteCheckIsDefaultEv -} -{ bug_90376 Memcheck:Cond fun:_ZN5views6Widget16SetInitialBoundsERKN3gfx4RectE |