diff options
| author | hartmanng@chromium.org <hartmanng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-16 14:46:44 +0000 |
|---|---|---|
| committer | hartmanng@chromium.org <hartmanng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-16 14:46:44 +0000 |
| commit | 6b192f37e66834a348af3b8afa8f2a74f5ef6016 (patch) | |
| tree | e20d878c78b726464cfc806d3bf5d9520f95c682 /tools | |
| parent | 3b4b1eb25a29838d280e990668f65af63d6d4070 (diff) | |
| download | chromium_src-6b192f37e66834a348af3b8afa8f2a74f5ef6016.zip chromium_src-6b192f37e66834a348af3b8afa8f2a74f5ef6016.tar.gz chromium_src-6b192f37e66834a348af3b8afa8f2a74f5ef6016.tar.bz2 | |
Removing environment variable as default value for 'cros_remote'.
This causes my benchmarks to crash when running
./run_multipage_benchmarks --browser=release scrolling_benchmark page_sets/top_25.json,
for example, as long as my REMOTE environment variable is set. Other approaches
to fix this could be to remove the check in browser_finder.py
(if options.browser_type != 'cros-chrome' and options.cros_remote != None)
or to add a separate check to only fail if this was specified by command-line
and not just by environment variable.
Personally, I think we can just do without this default value, but let me know
what you think.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11417013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168200 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/telemetry/telemetry/browser_options.py | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/tools/telemetry/telemetry/browser_options.py b/tools/telemetry/telemetry/browser_options.py index 01601c4..095ead9 100644 --- a/tools/telemetry/telemetry/browser_options.py +++ b/tools/telemetry/telemetry/browser_options.py @@ -2,7 +2,6 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. import optparse -import os import sys import shlex import logging @@ -62,9 +61,7 @@ class BrowserOptions(optparse.Values): group.add_option( '--remote', dest='cros_remote', - default=os.getenv('REMOTE'), - help='The IP address of a remote ChromeOS device to use. ' + - 'Defaults to $REMOTE from environment variable if set.') + help='The IP address of a remote ChromeOS device to use.') group.add_option('--identity', dest='cros_ssh_identity', default=None, |