summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authordkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-04-16 22:47:57 +0000
committerdkegel@google.com <dkegel@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-04-16 22:47:57 +0000
commit7a36977a1d983af47ee83aa71cd47d156fe9110e (patch)
treef237b4cb46785150a0c0c940fe213dec8e42bdab /tools
parent6b3f162b963e006c7be711ba02109b664bb24022 (diff)
downloadchromium_src-7a36977a1d983af47ee83aa71cd47d156fe9110e.zip
chromium_src-7a36977a1d983af47ee83aa71cd47d156fe9110e.tar.gz
chromium_src-7a36977a1d983af47ee83aa71cd47d156fe9110e.tar.bz2
chrome_tests.py needs to tell run_webkit_tests.py if it's a debug build
Review URL: http://codereview.chromium.org/79022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13893 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rwxr-xr-xtools/valgrind/chrome_tests.py9
1 files changed, 8 insertions, 1 deletions
diff --git a/tools/valgrind/chrome_tests.py b/tools/valgrind/chrome_tests.py
index 485b6a5..3bea91b 100755
--- a/tools/valgrind/chrome_tests.py
+++ b/tools/valgrind/chrome_tests.py
@@ -41,7 +41,7 @@ class ChromeTests:
'''
def __init__(self, options, args, test):
- # The known list of tests.
+ # The known list of tests.
# Recognise the original abbreviations as well as full executable names.
self._test_list = {
"base": self.TestBase, "base_unittests": self.TestBase,
@@ -254,6 +254,13 @@ class ChromeTests:
script_cmd = ["python", script, "--run-singly", "-v",
"--noshow-results", "--time-out-ms=200000",
"--nocheck-sys-deps"]
+ # Pass build mode to run_webkit_tests.py. We aren't passed it directly,
+ # so parse it out of build_dir. run_webkit_tests.py can only handle
+ # the two values "Release" and "Debug".
+ # TODO(Hercules): unify how all our scripts pass around build mode
+ # (--mode / --target / --build_dir / --debug)
+ if self._options.build_dir.endswith("Debug"):
+ script_cmd.append("--debug");
if (chunk_size > 0):
script_cmd.append("--run-chunk=%d:%d" % (chunk_num, chunk_size))
if len(self._args):