summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorsatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-03 06:26:10 +0000
committersatorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-06-03 06:26:10 +0000
commit8b8176670c5bd09a733c45b8a0967d5eb1b7dd2c (patch)
treeafc048d5ea2ab7be5be8a9b93af0537d91ba7ba5 /tools
parent55d36fd16c97d7053d5f8a9917465ae216744199 (diff)
downloadchromium_src-8b8176670c5bd09a733c45b8a0967d5eb1b7dd2c.zip
chromium_src-8b8176670c5bd09a733c45b8a0967d5eb1b7dd2c.tar.gz
chromium_src-8b8176670c5bd09a733c45b8a0967d5eb1b7dd2c.tar.bz2
Re-enable a disabled test in ThumbnailGenerator
Also write up a lengthy comment about why we think valgrind is wrong here. The suppression for this report is kept. Along the way, remove the suppresion for a memory leak in ThumbnailGenerator. The leak is gone now. TEST=confirm that valgrind doesn't complain by tools/valgrind/chrome_tests.sh -v -b ninja -t unit --tool_flags='--track-origins=yes' --gtest_filter='ThumbnailGenerator*' BUG=80458 Review URL: http://codereview.chromium.org/7074045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87757 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
-rw-r--r--tools/valgrind/memcheck/suppressions.txt6
1 files changed, 0 insertions, 6 deletions
diff --git a/tools/valgrind/memcheck/suppressions.txt b/tools/valgrind/memcheck/suppressions.txt
index e771de2..7ead114e 100644
--- a/tools/valgrind/memcheck/suppressions.txt
+++ b/tools/valgrind/memcheck/suppressions.txt
@@ -4303,12 +4303,6 @@
fun:_ZN8gtk_util*AppModal*
}
{
- bug_80458_a
- Memcheck:Leak
- fun:_Znw*
- fun:_ZN22ThumbnailGeneratorTestC2Ev
-}
-{
bug_80458_b
Memcheck:Cond
fun:_ZN22ThumbnailGeneratorTest18ClassifyFirstPixelERK8SkBitmap