diff options
| author | enal@chromium.org <enal@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-01 19:20:34 +0000 |
|---|---|---|
| committer | enal@chromium.org <enal@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-01 19:20:34 +0000 |
| commit | f02ad19b216c9287efd47e4b5cf8dbc402cc04a1 (patch) | |
| tree | fc6a93fe60318136b4eb764d8d33643471bb7a0e /tools | |
| parent | f12e6a4af0a2a883bee6295911501faaab8bf042 (diff) | |
| download | chromium_src-f02ad19b216c9287efd47e4b5cf8dbc402cc04a1.zip chromium_src-f02ad19b216c9287efd47e4b5cf8dbc402cc04a1.tar.gz chromium_src-f02ad19b216c9287efd47e4b5cf8dbc402cc04a1.tar.bz2 | |
Fix test -- we should initialize the buffer, otherwise valgrind/DrMemory reports
read from uninitialized memory. Mixer reads data from there, even though test
does not use mixed output.
BUG=125723
Review URL: http://codereview.chromium.org/10268026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134749 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/valgrind/drmemory/suppressions_full.txt | 9 | ||||
| -rw-r--r-- | tools/valgrind/memcheck/suppressions_mac.txt | 9 |
2 files changed, 0 insertions, 18 deletions
diff --git a/tools/valgrind/drmemory/suppressions_full.txt b/tools/valgrind/drmemory/suppressions_full.txt index 6e60fde..50f7a6d 100644 --- a/tools/valgrind/drmemory/suppressions_full.txt +++ b/tools/valgrind/drmemory/suppressions_full.txt @@ -1326,15 +1326,6 @@ name=http://crbug.com/125565 *!SiteInstanceImpl::GetProcess *!BrowserTestOffTheRecord_DelayProfileDestruction_Test::TestBody -# True uninit in media_unittests. -UNINITIALIZED READ -name=http://crbug.com/125723 -*!media::AddSaturated<*> -*!media::MixStreams<*> -*!media::MixStreams -*!media::AudioOutputMixer::OnMoreData -*!media::AudioOutputProxyTest_TwoStreams_BothPlaying_Mixer_Test::TestBody - LEAK name=http://crbug.com/125724 *!operator new diff --git a/tools/valgrind/memcheck/suppressions_mac.txt b/tools/valgrind/memcheck/suppressions_mac.txt index 3172522..7018eb0 100644 --- a/tools/valgrind/memcheck/suppressions_mac.txt +++ b/tools/valgrind/memcheck/suppressions_mac.txt @@ -2417,12 +2417,3 @@ fun:_ZN8remoting8protocol21AuthenticatorTestBase14RunChannelAuthEb fun:_ZN8remoting8protocol52NegotiatingAuthenticatorTest_SuccessfulAuthHmac_Test8TestBodyEv } -{ - bug_125728 - Memcheck:Uninitialized - fun:_ZN5mediaL12AddSaturatedIiLin32768ELi32767EEEiii - fun:_ZN5mediaL10MixStreamsIsiLin32768ELi32767ELi0EEEvPT_S2_if - fun:_ZN5media10MixStreamsEPvS0_mif - fun:_ZN5media16AudioOutputMixer10OnMoreDataEPhjNS_17AudioBuffersStateE - fun:_ZN5media54AudioOutputProxyTest_TwoStreams_BothPlaying_Mixer_Test8TestBodyEv -} |